Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style list sidebar does not change background of the Styles icon selected #11077

Closed
sebastiaanveld opened this issue Feb 3, 2025 · 5 comments
Assignees

Comments

@sebastiaanveld
Copy link
Contributor

Describe the Bug

Style list sidebar does not change background of the Styles icon selected; selecting any if the six options in the Styles sidebar always only show the backgrounhd of the first icon as selected. This makes it hard to see which option is selected. This is true for both Dark and Light mode.

Steps to Reproduce

  1. Open and document in Nextcloud for Editing with CODE
  2. Select Format> Style list
  3. Sidebare Styles appears, the first icon has the background painted as being selected.
  4. Now click any of the other 5 icons in the Styles sidebar: the backfound of the selected option does not show up as selected.

Expected Behavior

Backound of the icon selected in the Styles sidebar should show as being the selected one

Actual Behavior

Only the first icon on the left shows as being selected even when any of the other Styles option are selected in the sidebare.

Screenshots

When selecting the Style list in the Format tab/menu teh sidebar appears and the foirst option has the background set as being the selected option (which is correct;

Image

when the second icons of other icons are selected the backgound of the selected icon does not show as being the selected one, just the icon of the first option stays as it was being the selected option.

Image

Image

Desktop

  • OS: Windows 11 24H2, latest patches, x64 Dutch
  • Browser: Firefox
  • Version: 134.0.2, X64 Dutch

CODE

COOLWSD version: 24.04.12.2(git hash: 875c3b0 (E))
LOKit version: Collabora Office 24.04.12.2(git hash: 7b59930)
Served by: openSUSE Leap 15.5
Server ID: 8b19fbf0
WOPI host:

Additional Context

@Ezinnem
Copy link
Member

Ezinnem commented Feb 6, 2025

I can confirm the issue.

@pedropintosilva @Darshan-upadhyay1110 Please can you take a look?

@pedropintosilva
Copy link
Contributor

pedropintosilva commented Feb 7, 2025

Thank you @sebastiaanveld for taking the time to test the feature and report back. It really helps :)

This is already being worked by @banobepascal #11099

@banobepascal
Copy link

This is now fixed

https://gerrit.libreoffice.org/c/core/+/181170

#11099

@sebastiaanveld
Copy link
Contributor Author

sebastiaanveld commented Feb 7, 2025

Great thanks! I'll leave the ticket open until I've verified this in the next COOL release containting the fix.

@jazevedo-coll
Copy link

This is now fixed

https://gerrit.libreoffice.org/c/core/+/181170

Can confirm that.

Screencast.from.2025-02-07.12-41-25.webm

COOLWSD version: 24.04.12.3(git hash: bf3aefc)
LOKit version: Collabora OfficeDev 24.04.12.3(git hash: cd45b2a2fc)
Served by: Debian GNU/Linux 12 (bookworm)
Server ID: 8a727700
WOPI host: nextcloud 30.0.5.1 - richdocuments 8.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

5 participants