Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype for Presenter that support JSON, XML, and CSV #6

Closed
5 tasks done
tbsvttr opened this issue Oct 24, 2022 · 10 comments · Fixed by #20
Closed
5 tasks done

Prototype for Presenter that support JSON, XML, and CSV #6

tbsvttr opened this issue Oct 24, 2022 · 10 comments · Fixed by #20
Assignees
Labels
question Further information is requested

Comments

@tbsvttr
Copy link
Collaborator

tbsvttr commented Oct 24, 2022

@tbsvttr tbsvttr added the question Further information is requested label Oct 24, 2022
@PhilippHerda
Copy link
Collaborator

Flattening the nested structure for the CSV files is ok according to Paggy.

@PhilippHerda
Copy link
Collaborator

Shale (https://github.com/kgiszczak/shale) could be a potential all-in-one solution.

https://www.ruby-toolbox.com/projects/shale

@tbsvttr
Copy link
Collaborator Author

tbsvttr commented Oct 25, 2022

@PhilippHerda Ok. Please implement prototype.

@PhilippHerda PhilippHerda linked a pull request Oct 26, 2022 that will close this issue
@tbsvttr
Copy link
Collaborator Author

tbsvttr commented Oct 26, 2022

@PhilippHerda take note of this discussion many years ago in RABL: nesquena/rabl#262

@tbsvttr
Copy link
Collaborator Author

tbsvttr commented Oct 26, 2022

@PhilippHerda please also take a look at Grape Entity: ruby-grape/grape-entity#45

@tbsvttr
Copy link
Collaborator Author

tbsvttr commented Oct 28, 2022

All formats are compatible, because we can just flatten the structure.

@tbsvttr
Copy link
Collaborator Author

tbsvttr commented Oct 28, 2022

Shale (https://github.com/kgiszczak/shale) could be a potential all-in-one solution.

https://www.ruby-toolbox.com/projects/shale

I opened an issue over there concerning a release of a version that supports the CSV feature: kgiszczak/shale#14

I also opened an issue about the nested CSV problem: kgiszczak/shale#15

@tbsvttr
Copy link
Collaborator Author

tbsvttr commented Oct 28, 2022

The maintainer posted a solution for the nested CSV problem which would work, but create somewhat boilerplate: kgiszczak/shale#15 (comment)

He will release next week for us: kgiszczak/shale#14 (comment)

@tbsvttr
Copy link
Collaborator Author

tbsvttr commented Oct 31, 2022

He has released 0.9. I included it in the branch.

Still discussion some details about CSV with him.

@tbsvttr
Copy link
Collaborator Author

tbsvttr commented Nov 7, 2022

Basic presenter works now. Creating new issue for nested CSV problem.

@tbsvttr tbsvttr closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants