Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal commands #237

Merged
merged 15 commits into from
Nov 19, 2024
Merged

Terminal commands #237

merged 15 commits into from
Nov 19, 2024

Conversation

pythongosssss
Copy link
Member

Add support for executing commands via terminal

Copy link

socket-security bot commented Nov 13, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
HTTP dependency npm/@electron/[email protected] ⚠︎

View full report↗︎

Next steps

What are http dependencies?

Contains a dependency which resolves to a remote HTTP URL which could be used to inject untrusted code and reduce overall package reliability.

Publish the HTTP URL dependency to npm or a private package repository and consume it from there.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

src/main.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 16, 2024

The author of this PR, pythongosssss, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

Copy link

socket-security bot commented Nov 17, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@electron/[email protected] environment, shell 0 1.85 MB electronhq
npm/@electron/[email protected] environment, filesystem, network, shell 0 162 kB electron-cfa
npm/@gar/[email protected] None 0 4.2 kB gar
npm/@szmarczak/[email protected] None 0 10.8 kB szmarczak
npm/@tootallnate/[email protected] None 0 16.3 kB tootallnate
npm/[email protected] network 0 16.8 kB jaredwray
npm/[email protected] None 0 4.37 kB sindresorhus
npm/[email protected] None 0 11.1 kB pvorb
npm/[email protected] None 0 5.47 kB sindresorhus
npm/[email protected] filesystem, network 0 269 kB sindresorhus
npm/[email protected] filesystem 0 4.29 kB isaacs
npm/[email protected] None 0 3.54 kB sindresorhus
npm/[email protected] None 0 27.8 kB jaredwray
npm/[email protected] environment, filesystem, network, shell 0 1.14 MB tyriar
npm/[email protected] None 0 3.04 kB iarna
npm/[email protected] None 0 4.68 kB sindresorhus
npm/[email protected] None 0 2.82 kB sindresorhus
npm/[email protected] None 0 32.1 kB feross

🚮 Removed packages: npm/@electron/[email protected], npm/@sindresorhus/[email protected], npm/@szmarczak/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

src/main.ts Outdated Show resolved Hide resolved
@robinjhuang robinjhuang merged commit 9df7b39 into main Nov 19, 2024
7 checks passed
@robinjhuang robinjhuang deleted the terminal-commands branch November 19, 2024 00:50
robinjhuang added a commit that referenced this pull request Nov 19, 2024
robinjhuang added a commit that referenced this pull request Nov 19, 2024
robinjhuang added a commit that referenced this pull request Nov 19, 2024
robinjhuang added a commit that referenced this pull request Nov 20, 2024
robinjhuang added a commit that referenced this pull request Nov 20, 2024
* Revert "Revert "Terminal commands (#237)" (#291)"

This reverts commit 6848467.

* Add electron-builder version to 25+.

* Add node-abi

* Remove node-abi.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants