Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic installation validation #554

Merged
merged 17 commits into from
Dec 24, 2024
Merged

Add basic installation validation #554

merged 17 commits into from
Dec 24, 2024

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Dec 24, 2024

The changes required for install validation / repair have been split into smaller chunks. The most significant changes are in this PR - it includes most of the refactoring.

  • Restructures app startup
  • Splits installation code out of ComfyDesktopApp
  • Adds validation framework to allow resume / repair installation
  • Splits config store classes out to separate files

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered requested a review from a team as a code owner December 24, 2024 05:52
@huchenlei huchenlei merged commit 0d54841 into main Dec 24, 2024
7 checks passed
@huchenlei huchenlei deleted the app-state branch December 24, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants