Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 ⚙️ Implementation rules and drivers #3

Open
Zales0123 opened this issue Apr 5, 2023 · 0 comments
Open

📖 ⚙️ Implementation rules and drivers #3

Zales0123 opened this issue Apr 5, 2023 · 0 comments

Comments

@Zales0123
Copy link
Member

Implementation rules and drivers

⚙️ Supported versions

  1. Repository should support only PHP ^8.0 version
  2. At the beginning, the supported Sylius versions are ^1.10 (so 3 minor versions that should be properly tested in the CI). In the future we shall move to ^1.12 support only

📝 Testing

  1. All crucial paths of the payment flow (happy path, canceled payment, failed payment etc.) shall be covered with the Behat scenarios
  2. To avoid calling the test API in them, we would use Mockoon tool, to mock the responses in the CI
  3. All essential API calls to the Saferpay API should be covered with contract tests that would be run once a day (to not call the real API too often, but to be aware of any changes in the API contract)
  4. All classes with any behavior should be covered with PHPSpec tests

💻 DX and debugging

  1. All the new configurations should use php files rather than yaml. All the existing configurations shall be migrated to php.
  2. All the important information about the payment flow (both success and failure) should be logged in the dedicated log panel. Errors should also be logged in the separated saferpay.log file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant