Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of _contribute() #12

Open
sembrestels opened this issue Oct 26, 2021 · 0 comments · May be fixed by #17
Open

Improve performance of _contribute() #12

sembrestels opened this issue Oct 26, 2021 · 0 comments · May be fixed by #17
Labels
enhancement New feature or request Sohkai's review

Comments

@sembrestels
Copy link
Contributor

From sohkai's review: _contribute()'s token branch can be streamlined by removing the balanceOf() and allowance() checks: these are already checked in the token's transferFrom().
@sembrestels sembrestels added enhancement New feature or request Sohkai's review labels Oct 26, 2021
sembrestels added a commit that referenced this issue Oct 27, 2021
@sembrestels
Improve performance of _contribute() (fixes #12)
0157e03
@sembrestels sembrestels linked a pull request Oct 27, 2021 that will close this issue
Fixes to Sohkai review #17
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Sohkai's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes to Sohkai review CommonsSwarm/hatch-app
1 participant
@sembrestels