-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private HTML resources not displaying as expected #41
Comments
Can you give more detail. |
Missed important detail in copying this from another channel: The HTML page is displayed when the resource is public, however if the resource is private and the user is authenticated, you get the SolidOS page instead of the HTML page in your Pod. This issue is observed on https://timbl.com, I would assume that it is the default mashlib configuration - but cannot guarantee. I will follow up. cc @timbl |
Can confirm this is an issue with the default maslib config here. If you follow the instructions in #43 and then go to the url for the |
@jeswr Could you try to add Recipes/mashlib/config-mashlib.json Lines 53 to 56 in 208d9bc
This should also resolve the dokieli issue #43 |
The good solution should be to replace
|
@bourgeoa - it looks like that is already an option, which defaults to |
To clarify, is the request to change the config to have "options_enabledMediaRanges": [
"text/turtle",
"text/n3",
"application/xhtml+xml",
"application/n3",
"application/nquads",
"application/n-quads",
"application/rdf+xml",
"application/ld+json",
"application/x-turtle"
] instead of the current disabled media ranges. And this would also solve #43? |
Yes it was the idea but I tried it and it does not load mashlib as ui |
I was not detailed enough :
|
Was not resolved in CommunitySolidServer/CommunitySolidServer#1983 |
Thinking about this, I'm not sure how possible it actually is to do this. Since the resource is private, an authenticated fetch needs to take place in the JS code, so you can't just redirect the browser to the page to have the browser render it. Similar as discussed in CommunitySolidServer/CommunitySolidServer#1392 Only solution I can think of is mashlib rendering an iframe with the response HTML it gets from the authenticated request? |
Tried
no effect on the issue. |
The strange thing is that private text/plain or private text/markdown don't have this issue |
But how does mashlib solve that situation then? As an authenticated fetch still has to happen at some point there. |
Mashlib use an authenticated fetch and iFrame to resolve these issues CommunitySolidServer/CommunitySolidServer#1392 In the text/html case it does not work and we kept the former solution. |
When you go to the URL of an HTML resource whilst authenticated, you get the SolidOS page in which you can view the HTML source - instead of the HTML page itself.
The text was updated successfully, but these errors were encountered: