[googlecast] Fix warnings in the sample app (#17)

The google cast sample has been updated to resolve all build warnings and improve formatting.
CommunityToolkit · Apr 30, 2024 · 03f352a · 03f352a
1 parent 2883b92
commit 03f352a
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 12 deletions.
diff --git a/googlecast/macios/README.md b/googlecast/macios/README.md
@@ -0,0 +1,12 @@
+# Google Cast Slim Binding
+This folder contains a slim binding for the Google Cast SDK.
+
+### Build and Run
+```shell
+    dotnet build sample -t:Run
+```
+
+### Configure
+For more details, reference the [Get Started][0] page.
+
+[0]: https://developers.google.com/cast
diff --git a/googlecast/macios/sample/GoogleCast.Sample.csproj b/googlecast/macios/sample/GoogleCast.Sample.csproj
@@ -1,10 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
 	<PropertyGroup>
-		<TargetFrameworks>net8.0-ios</TargetFrameworks>
-		<!-- <TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);net8.0-windows10.0.19041.0</TargetFrameworks> -->
-		<!-- Uncomment to also build the tizen app. You will need to install tizen by following this: https://github.com/Samsung/Tizen.NET -->
-		<!-- <TargetFrameworks>$(TargetFrameworks);net8.0-tizen</TargetFrameworks> -->
+		<TargetFramework>net8.0-ios</TargetFramework>
 
 		<!-- Note for MacCatalyst:
 		The default runtime is maccatalyst-x64, except in Release config, in which case the default is maccatalyst-x64;maccatalyst-arm64.

diff --git a/googlecast/macios/sample/MainPage.xaml b/googlecast/macios/sample/MainPage.xaml
@@ -14,6 +14,11 @@
                 Aspect="AspectFit"
                 SemanticProperties.Description="dot net bot in a race car number eight" />
 
+            <Label
+                Text="Google Cast Demo"
+                Style="{StaticResource Headline}"
+                SemanticProperties.HeadingLevel="Level1" />
+
             <Label
                 Text="Click the icon below to start Google Cast"
                 Style="{StaticResource SubHeadline}"/>

diff --git a/googlecast/macios/sample/MainPage.xaml.cs b/googlecast/macios/sample/MainPage.xaml.cs
@@ -2,16 +2,14 @@
 
 public partial class MainPage : ContentPage
 {
-	int count = 0;
-
 	public MainPage()
 	{
 		InitializeComponent();	
 	}
 
-    protected override async void OnAppearing()
-    {
-        base.OnAppearing();
+	protected override async void OnAppearing()
+	{
+		base.OnAppearing();
 
 		if (googleCastManager is null)
 		{
@@ -22,13 +20,13 @@ protected override async void OnAppearing()
 			await Permissions.RequestAsync<Permissions.NetworkState>();
 			#endif
 		}
-    }
+	}
 
-    GoogleCast.GoogleCastManager googleCastManager;
+	GoogleCast.GoogleCastManager? googleCastManager;
 
 	private void OnCounterClicked(object sender, EventArgs e)
 	{
-		googleCastManager.LoadMedia("https://www.sample-videos.com/video123/mp4/720/big_buck_bunny_720p_1mb.mp4",
+		googleCastManager?.LoadMedia("https://www.sample-videos.com/video123/mp4/720/big_buck_bunny_720p_1mb.mp4",
 			"video/mp4",
 			"Big Buck Bunny",
 			"Big Buck Bunny (open-source movie)",