Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find better BeforeTargets for Common.*.targets #2

Closed
Redth opened this issue Apr 4, 2024 · 2 comments
Closed

Find better BeforeTargets for Common.*.targets #2

Redth opened this issue Apr 4, 2024 · 2 comments

Comments

@Redth
Copy link
Collaborator

Redth commented Apr 4, 2024

Currently using a target that causes the BuildXCFramework and BuildAar targets to run too often (including in a nuget restore build pass).

Need to look for a better target to use for each platform. There is something like CollectNativeReferences on iOS and _ResolveAars on Android (which they inject into CoreResolveReferencesDependsOn)

@pjcollins
Copy link
Collaborator

This should be slightly improved by #15 via:

https://github.com/Redth/DotNet.Platform.SlimBindings/pull/15/files#diff-236b52437f49e99579d42ec96e008395e33c185e8d331efe41b985b9310e0890R25

https://github.com/Redth/DotNet.Platform.SlimBindings/pull/15/files#diff-cb7e40267b52d3998ef1e84c108fb5189594d1151d694001c550a223538a2d02R40-R46

Though I will be revisiting this when introducing MSBuild tasks, as this doesn't work perfectly with projects that multitarget ios/mac.

@pjcollins
Copy link
Collaborator

Fixes for multitargeting landed in #22, going to close this as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants