Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hint to README.md to add PrivateAssets tag #32

Closed
thisisthekap opened this issue Jun 25, 2024 · 0 comments · Fixed by #37
Closed

Add hint to README.md to add PrivateAssets tag #32

thisisthekap opened this issue Jun 25, 2024 · 0 comments · Fixed by #37

Comments

@thisisthekap
Copy link

When building libraries, the binding helper nuget is exposed as dependency if referenced as given in the examples. I suggest to add a README.md section describing the use of PrivateAssets to prevent this behavior.
pjcollins added a commit that referenced this issue Jul 10, 2024
@pjcollins
Set PrivateAssets=all for BuildTasks helper package ref
9030ad6 
Fixes: #32

Ensures the BuildTasks helper package will not be transitive dependency
of the binding projects.
@pjcollins pjcollins mentioned this issue Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set PrivateAssets=all for BuildTasks helper package ref CommunityToolkit/Maui.NativeLibraryInterop
1 participant
@thisisthekap