Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Add gradle build task #19

Merged
merged 1 commit into from
May 13, 2024

Conversation

pjcollins
Copy link
Collaborator

@pjcollins pjcollins commented May 1, 2024

Introduces a new @(GradleProjectReference) item to help simplify the
content that needs to be added to the binding .csproj file. This item
will translate relevant metadata to the @(AndroidLibrary) item that is
automatically added to the project after the gradle project is built.

A gradle build task has been added to improve msbuild output and error
logging when a gradle invocation fails.

We will now attempt to set $ANDROID_HOME and $JAVA_HOME
automatically when invoking gradle. These values will be determined by
Android SDK tooling resolution tasks, and can be changed by setting
$(AndroidSdkDirectory) and $(JavaSdkDirectory) in the project file or
on the command line.

<Pack>true</Pack>
<Visible>false</Visible>
</AndroidLibrary>
<GradleProjectReference Include="../native" ModuleName="mauifacebook" />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially include more metadata here as an example

Introduces a new `@(GradleProjectReference)` item to help simplify the
content that needs to be added to the binding .csproj file.  This item
will translate relevant metadata to the `@(AndroidLibrary)` item that is
automatically added to the project after the gradle project is built.

A gradle build task has been added to improve msbuild output and error
logging when a gradle invocation fails.

We will now attempt to set `$ANDROID_HOME` and `$JAVA_HOME`
automatically when invoking gradle.  These values will be determined by
Android SDK tooling resolution tasks, and can be changed by setting
`$(AndroidSdkDirectory)` and `$(JavaSdkDirectory)` in the project file or
on the command line.
@pjcollins pjcollins marked this pull request as ready for review May 13, 2024 15:30
@pjcollins pjcollins merged commit b06188f into CommunityToolkit:main May 13, 2024
1 check passed
@pjcollins pjcollins deleted the android-tasks branch May 13, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant