Replies: 13 comments
-
Interesting proposition, curious what others think. Could you create a uservoice for this and provide a bit more details? |
Beta Was this translation helpful? Give feedback.
-
@nmetulev |
Beta Was this translation helpful? Give feedback.
-
Thanks. :) pulling in @hermitdave to the conversation |
Beta Was this translation helpful? Give feedback.
-
Could probably be an extension of #1100 - that already creates an ImageBrush using the image cache internally for use with it's RoundedImage control |
Beta Was this translation helpful? Give feedback.
-
Yes @JohnnyWestlake precisely my thoughts on this. We should just wrap and expose the brush from RoundedImageEx. |
Beta Was this translation helpful? Give feedback.
-
Having looked at it further, I believe that in order to provide ImageEx Brush, we would need to ditch the shared code for ImageExBase. ImageExBrush would inherit from TileBrush and implement additional bits as needed. Whilst this isn't difficult, I just want us to be on the same page. |
Beta Was this translation helpful? Give feedback.
-
What's the current status of this issue? |
Beta Was this translation helpful? Give feedback.
-
@h82258652 what's the status on this? |
Beta Was this translation helpful? Give feedback.
-
I don't know, it seems no one is handling this. |
Beta Was this translation helpful? Give feedback.
-
@Sergio0694 thoughts on how our existing ImageBlendBrush and the above would fit/work with your Pipeline brushes #3112? |
Beta Was this translation helpful? Give feedback.
-
This is (somewhat) already possible with the pipeline API, like so: <Rectangle>
<Rectangle.Fill>
<brushes:PipelineBrush>
<brushes:PipelineBrush.Effects>
<effects:ImageEffect
Uri="/Assets/SomeImage.png"
DPIMode="DisplayDpi"/>
</brushes:PipelineBrush.Effects>
</brushes:PipelineBrush>
</Rectangle.Fill>
</Rectangle> It would definitely be possible to reuse the same internal APIs and expose a some brush type with also more properties on top. Or better yet, add more options directly to that This is basically what the updated brushes like the |
Beta Was this translation helpful? Give feedback.
-
@h82258652 ⬆️ |
Beta Was this translation helpful? Give feedback.
-
@Sergio0694 I guess the things missing in the Pipeline Brushes and the ImageBlendBrush in the toolkit would be the Alignment properties from @h82258652's example? Would it make sense to try and rebase |
Beta Was this translation helpful? Give feedback.
-
In 15063, we can extend brush (by
XamlCompositionBrushBase
). How about create aImageBrushEx
?I create my own here: https://github.com/h82258652/Projects/blob/dev/Libraries/SoftwareKobo.Controls.ImageEx.Uwp.15063/ImageBrushEx.cs
Beta Was this translation helpful? Give feedback.
All reactions