Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using :scss + sass-rails the sass_importer.rb patch now blows up #238

Closed
reidnimz opened this issue Apr 27, 2015 · 0 comments
Closed

Comments

@reidnimz
Copy link
Contributor

I'm using:
compass-rails 2.0.4
sass-rails 5.0.1
haml-rails 0.8.2

When I attempt to use an :scss block in a haml template, I get the following error:
uninitialized constant Haml::Filters::SassImporter

The reason seems to be the following commit in sass-rails that made Sass::Rails::SassTemplate no longer a subclass of Sprockets::SassTemplate
rails/sass-rails@e123a39

I believe that the fix (which works for me locally) is to remove the class selection at the top of sass_importer.rb and just go with Sprockets::SassTemplate.class_eval(...) but I'm not very familiar with most of what is going on in here, so I wanted to check with folks familiar with the code to find out if that would break something (@twalpole I'm tagging you because you made the change).

There is a related but in the haml-rails project: haml/haml-rails#77 - but I'm pretty sure the change should happen in compass-rails.

I'll try and submit a PR as soon as I'm able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants