FIX Some SonarCloud issues reported

CompassionCH · May 9, 2022 · a38ac37 · a38ac37
1 parent 414940e
commit a38ac37
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 11 deletions.
diff --git a/account_reconcile_compassion/wizards/change_attribution_wizard.py b/account_reconcile_compassion/wizards/change_attribution_wizard.py
@@ -88,7 +88,7 @@ def unreconcile(self):
                         {
                             "date_invoice": invoice.date_invoice,
                             "comment": self.comment
-                            or "New invoice after " "payment attribution changed.",
+                            or "New invoice after payment attribution changed.",
                             "invoice_line_ids": False,
                         }
                     )

diff --git a/child_sync_wp/tools/wp_sync.py b/child_sync_wp/tools/wp_sync.py
@@ -36,7 +36,7 @@ def parse_response(self, response):
             if not data:
                 break
             if self.verbose:
-                _logger.info("body:", repr(data))
+                _logger.info("body: " + repr(data))
             p.feed(data)
 
         if stream is not response:
@@ -116,7 +116,7 @@ def upload_children(self, children):
                     "Child Upload partially failed."
                     + str(count_insert)
                     + " of "
-                    + len(children)
+                    + str(len(children))
                 )
             else:
                 _logger.error("Child Upload failed.")

diff --git a/crm_switzerland/views/crm_phonecall.xml b/crm_switzerland/views/crm_phonecall.xml
@@ -12,6 +12,5 @@
 
     <record id="crm_phone.crm_phonecall_action_open" model="ir.actions.act_window">
         <field name="context">{'search_default_my_calls': 1, 'search_default_open': 1, 'default_state': 'open'}</field>
-        <!--<field name="search_view_id" ref="crm.phonecall.search"/>-->
     </record>
 </odoo>
diff --git a/muskathlon/forms/trip_forms.py b/muskathlon/forms/trip_forms.py
@@ -113,12 +113,11 @@ def _form_validate_passport_expiration_date(self, value, **req_values):
             valid = not old
         except (ValueError, TypeError):
             valid = False
-        finally:
-            if not valid:
-                message = _("Please enter a valid date")
-                if old:
-                    message = _("Your passport must be renewed!")
-                return "passport_expiration_date", message
+        if not valid:
+            message = _("Please enter a valid date")
+            if old:
+                message = _("Your passport must be renewed!")
+            return "passport_expiration_date", message
         # No error
         return 0, 0
 

diff --git a/partner_communication_switzerland/wizards/communication_test_cases_wizard.py b/partner_communication_switzerland/wizards/communication_test_cases_wizard.py
@@ -94,7 +94,6 @@ def generate_test_cases_partner(self):
         self.ensure_one()
         if not self.partner_selected:
             raise exceptions.UserError("No partner selected")
-            return False
         case = self.config_id.generate_test_case_by_partner(
             self.partner, self.child_ids, self.send_mode)
         self._apply_cases([case])