Skip to content

Commit ebb79d2

Browse files
jan-cernyjan-cerny
authored
Merge pull request #13259 from xiaojiey/fix-OCPBUGS-38312
OCPBUGS-38312: Add auto-remediation for rule service_systemd-coredump_disabled
2 parents a8c9174 + fdb4450 commit ebb79d2

File tree

15 files changed

+47
-16
lines changed

15 files changed

+47
-16
lines changed

‎linux_os/guide/system/permissions/restrictions/coredumps/service_systemd-coredump_disabled/kubernetes/shared.yml‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# platform = multi_platform_rhcos
2+
# reboot = true
3+
# strategy = disable
4+
# complexity = low
5+
# disruption = medium
6+
apiVersion: machineconfiguration.openshift.io/v1
7+
kind: MachineConfig
8+
spec:
9+
config:
10+
ignition:
11+
version: 3.1.0
12+
systemd:
13+
units:
14+
- name: systemd-coredump.socket
15+
enabled: false
16+
mask: true
17+
- name: systemd-coredump.service
18+
enabled: false
19+
mask: true

‎tests/assertions/ocp4/rhcos4-high-4.12.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,7 @@ rule_results:
605605
result_after_remediation: PASS
606606
e2e-high-master-service-systemd-coredump-disabled:
607607
default_result: FAIL
608-
result_after_remediation: FAIL
608+
result_after_remediation: PASS
609609
e2e-high-master-service-usbguard-enabled:
610610
default_result: FAIL
611611
result_after_remediation: PASS
@@ -1329,7 +1329,7 @@ rule_results:
13291329
result_after_remediation: PASS
13301330
e2e-high-worker-service-systemd-coredump-disabled:
13311331
default_result: FAIL
1332-
result_after_remediation: FAIL
1332+
result_after_remediation: PASS
13331333
e2e-high-worker-service-usbguard-enabled:
13341334
default_result: FAIL
13351335
result_after_remediation: PASS

‎tests/assertions/ocp4/rhcos4-high-4.13.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,7 @@ rule_results:
605605
result_after_remediation: PASS
606606
e2e-high-master-service-systemd-coredump-disabled:
607607
default_result: FAIL
608-
result_after_remediation: FAIL
608+
result_after_remediation: PASS
609609
e2e-high-master-service-usbguard-enabled:
610610
default_result: FAIL
611611
result_after_remediation: PASS
@@ -1329,7 +1329,7 @@ rule_results:
13291329
result_after_remediation: PASS
13301330
e2e-high-worker-service-systemd-coredump-disabled:
13311331
default_result: FAIL
1332-
result_after_remediation: FAIL
1332+
result_after_remediation: PASS
13331333
e2e-high-worker-service-usbguard-enabled:
13341334
default_result: FAIL
13351335
result_after_remediation: PASS

‎tests/assertions/ocp4/rhcos4-high-4.14.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,7 @@ rule_results:
605605
result_after_remediation: PASS
606606
e2e-high-master-service-systemd-coredump-disabled:
607607
default_result: FAIL
608-
result_after_remediation: FAIL
608+
result_after_remediation: PASS
609609
e2e-high-master-service-usbguard-enabled:
610610
default_result: FAIL
611611
result_after_remediation: PASS
@@ -1329,7 +1329,7 @@ rule_results:
13291329
result_after_remediation: PASS
13301330
e2e-high-worker-service-systemd-coredump-disabled:
13311331
default_result: FAIL
1332-
result_after_remediation: FAIL
1332+
result_after_remediation: PASS
13331333
e2e-high-worker-service-usbguard-enabled:
13341334
default_result: FAIL
13351335
result_after_remediation: PASS

‎tests/assertions/ocp4/rhcos4-high-4.15.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -604,6 +604,7 @@ rule_results:
604604
result_after_remediation: PASS
605605
e2e-high-master-service-systemd-coredump-disabled:
606606
default_result: FAIL
607+
result_after_remediation: PASS
607608
e2e-high-master-service-usbguard-enabled:
608609
default_result: FAIL
609610
result_after_remediation: PASS
@@ -1324,6 +1325,7 @@ rule_results:
13241325
result_after_remediation: PASS
13251326
e2e-high-worker-service-systemd-coredump-disabled:
13261327
default_result: FAIL
1328+
result_after_remediation: PASS
13271329
e2e-high-worker-service-usbguard-enabled:
13281330
default_result: FAIL
13291331
result_after_remediation: PASS

‎tests/assertions/ocp4/rhcos4-high-4.16.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -604,6 +604,7 @@ rule_results:
604604
result_after_remediation: PASS
605605
e2e-high-master-service-systemd-coredump-disabled:
606606
default_result: FAIL
607+
result_after_remediation: PASS
607608
e2e-high-master-service-usbguard-enabled:
608609
default_result: FAIL
609610
result_after_remediation: PASS
@@ -1324,6 +1325,7 @@ rule_results:
13241325
result_after_remediation: PASS
13251326
e2e-high-worker-service-systemd-coredump-disabled:
13261327
default_result: FAIL
1328+
result_after_remediation: PASS
13271329
e2e-high-worker-service-usbguard-enabled:
13281330
default_result: FAIL
13291331
result_after_remediation: PASS

‎tests/assertions/ocp4/rhcos4-high-4.17.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,7 @@ rule_results:
605605
result_after_remediation: PASS
606606
e2e-high-master-service-systemd-coredump-disabled:
607607
default_result: FAIL
608-
result_after_remediation: FAIL
608+
result_after_remediation: PASS
609609
e2e-high-master-service-usbguard-enabled:
610610
default_result: FAIL
611611
result_after_remediation: PASS
@@ -1329,7 +1329,7 @@ rule_results:
13291329
result_after_remediation: PASS
13301330
e2e-high-worker-service-systemd-coredump-disabled:
13311331
default_result: FAIL
1332-
result_after_remediation: FAIL
1332+
result_after_remediation: PASS
13331333
e2e-high-worker-service-usbguard-enabled:
13341334
default_result: FAIL
13351335
result_after_remediation: PASS

‎tests/assertions/ocp4/rhcos4-high-4.18.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,7 @@ rule_results:
605605
result_after_remediation: PASS
606606
e2e-high-master-service-systemd-coredump-disabled:
607607
default_result: FAIL
608-
result_after_remediation: FAIL
608+
result_after_remediation: PASS
609609
e2e-high-master-service-usbguard-enabled:
610610
default_result: FAIL
611611
result_after_remediation: PASS
@@ -1329,7 +1329,7 @@ rule_results:
13291329
result_after_remediation: PASS
13301330
e2e-high-worker-service-systemd-coredump-disabled:
13311331
default_result: FAIL
1332-
result_after_remediation: FAIL
1332+
result_after_remediation: PASS
13331333
e2e-high-worker-service-usbguard-enabled:
13341334
default_result: FAIL
13351335
result_after_remediation: PASS

‎tests/assertions/ocp4/rhcos4-moderate-4.12.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -602,7 +602,7 @@ rule_results:
602602
result_after_remediation: PASS
603603
e2e-moderate-master-service-systemd-coredump-disabled:
604604
default_result: FAIL
605-
result_after_remediation: FAIL
605+
result_after_remediation: PASS
606606
e2e-moderate-master-service-usbguard-enabled:
607607
default_result: FAIL
608608
result_after_remediation: PASS
@@ -1323,7 +1323,7 @@ rule_results:
13231323
result_after_remediation: PASS
13241324
e2e-moderate-worker-service-systemd-coredump-disabled:
13251325
default_result: FAIL
1326-
result_after_remediation: FAIL
1326+
result_after_remediation: PASS
13271327
e2e-moderate-worker-service-usbguard-enabled:
13281328
default_result: FAIL
13291329
result_after_remediation: PASS

‎tests/assertions/ocp4/rhcos4-moderate-4.13.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -601,6 +601,7 @@ rule_results:
601601
result_after_remediation: PASS
602602
e2e-moderate-master-service-systemd-coredump-disabled:
603603
default_result: FAIL
604+
result_after_remediation: PASS
604605
e2e-moderate-master-service-usbguard-enabled:
605606
default_result: FAIL
606607
result_after_remediation: PASS
@@ -1318,6 +1319,7 @@ rule_results:
13181319
result_after_remediation: PASS
13191320
e2e-moderate-worker-service-systemd-coredump-disabled:
13201321
default_result: FAIL
1322+
result_after_remediation: PASS
13211323
e2e-moderate-worker-service-usbguard-enabled:
13221324
default_result: FAIL
13231325
result_after_remediation: PASS

0 commit comments

Comments
 (0)