Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all the duplicated code and move it up the inheritance hierarchy. #96

Open
gtato opened this issue Nov 9, 2015 · 0 comments
Open

Comments

@gtato
Copy link
Contributor

gtato commented Nov 9, 2015

There are 3 main areas where the code is duplicated: in the service managers, in the agents and in the web frontend. There may be a little duplicated code even in the command line tools.

In the case of service managers, we need to implement a class hierarchy with a BaseManager class, an ApplicationManager class and a ServiceManager class. All the concrete service manager classes should be derived from the ServiceManager class. All the functionality that may be useful to more than one service should be moved to this ServiceManager class. The functionality that is shared between the service managers and the Application Manager should be kept in the BaseManager class.
The same needs to be done in the case of agents. All the common functionality should be moved to the BaseAgent class.

The reorganization of the code in the web frontend has at the moment a lower priority

@gtato gtato added this to the ConPaaS-2.0.0 milestone Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants