Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buffer as peer dependency #250

Open
limemloh opened this issue Aug 29, 2023 · 1 comment
Open

Remove buffer as peer dependency #250

limemloh opened this issue Aug 29, 2023 · 1 comment
Labels
Breaking changes Implementation of the issue will cause breaking changes. [Type] Change Request Some visible functionality should be change.

Comments

@limemloh
Copy link
Collaborator

Description

When using the SDK, the user will need to install buffer as a dependency, since types from this library is exposed in the public API of our SDK.
Currently, we don't list it as a peerDependency in package.json and we could fix that, but IMO it would be more appropriate to only expose ArrayBuffer and only use buffer internally.

@limemloh limemloh added the [Type] Change Request Some visible functionality should be change. label Aug 29, 2023
@soerenbf
Copy link
Collaborator

I agree. We can still resolve to the browser-specific implementation in the web target, but it does feel awkward to have to use "our" version of buffer even in the node SDK, when the platform has it as a native type as well (and if you use the native type with typescript, you get type errors).

@soerenbf soerenbf added the Breaking changes Implementation of the issue will cause breaking changes. label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking changes Implementation of the issue will cause breaking changes. [Type] Change Request Some visible functionality should be change.
Projects
None yet
Development

No branches or pull requests

2 participants