Generate connector docs #200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying conduit-site with
|
| Latest commit: |
ed77f8e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://28b03f5e.conduit-site.pages.dev |
| Branch Preview URL: | https://haris-generate-connector-doc.conduit-site.pages.dev |
hariso
commented
Dec 9, 2024
hariso
commented
Dec 9, 2024
raulb
reviewed
Dec 19, 2024
There was a problem hiding this comment.
@hariso on https://github.com/ConduitIO/conduit-site/pull/203/files#diff-7a45f875fcea055cb151d9ae10b11385301584ae2bd1a9b111ea0b6c8e307c66, I went through the process of removing the artifacts and only link to the latest release which means we would be able to remove the IsLatest release check. I believe we should simplify that bit, and only show the relevant information there.
Another suggestion I have is to use the name of the connector as a link instead of expanding the accordion of releases, eliminating the View docs link.
What do you think?
…conduit-site into haris/generate-connector-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #167.
Here's how the updated connectors' list and a new connector's page look like:
Connectors list (and search)
A generated page