Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Not all configuration is correctly parsed #2062

Open
raulb opened this issue Jan 10, 2025 · 0 comments
Open

Bug: Not all configuration is correctly parsed #2062

raulb opened this issue Jan 10, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@raulb
Copy link
Member

raulb commented Jan 10, 2025

Bug description

Caution

This issue is not part of any minor release, but needs to be fixed before 0.13.0

With the recent addition of ecdysis taking care of the configuration parsing, it looks like not all options are correctly parsed. Notice in the following example how log.level is configured correctly, but not grpc.address.

$ go run ./cmd/conduit/main.go config --grpc.address :8085 --log.level warn
....
grpc.address: :8084
log.level: warn
...

@lovromazgon also noticed that config.path is another that's not parsed correctly.

The bug fix might need to occur in https://github.com/ConduitIO/ecdysis, but I am tracking it here for better visibility at the moment.

It's important we fix this issue because the configuration shown via conduit config command is the one that will be used on conduit run

Steps to reproduce

  1. Check out latest code from the main branch.
  2. Run conduit config with some configuration options.
  3. Notice not all are respected.

Version

v0.13.0-nightly.20250110

@raulb raulb added bug Something isn't working triage Needs to be triaged labels Jan 10, 2025
@raulb raulb mentioned this issue Jan 10, 2025
36 tasks
@raulb raulb moved this from Triage to Todo in Conduit Main Jan 10, 2025
@raulb raulb removed the triage Needs to be triaged label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant