From 9a13d464579f16be9a2419764698e9b2530aee8d Mon Sep 17 00:00:00 2001
From: madelinemurray <madeline.murray@consensys.net>
Date: Wed, 29 Nov 2023 16:21:34 +1000
Subject: [PATCH 1/2] Added gcp command line options

Signed-off-by: madelinemurray <madeline.murray@consensys.net>
---
 docs/reference/cli/subcommands.md | 100 ++++++++++++++++++++++++++++++
 1 file changed, 100 insertions(+)

diff --git a/docs/reference/cli/subcommands.md b/docs/reference/cli/subcommands.md
index 37c8716..c4c4fdf 100644
--- a/docs/reference/cli/subcommands.md
+++ b/docs/reference/cli/subcommands.md
@@ -1454,6 +1454,106 @@ eth2.azure-vault-name: "AzureKeyVault"
 Name of the vault to access.
 Subdomain of `vault.azure.net`.
 
+#### `gcp-project-id`
+
+<!--tabs-->
+
+# Syntax
+
+```bash
+--gcp-project-id=<STRING>
+```
+
+# Example
+
+```bash
+--gcp-project-id=my-project
+```
+
+# Environment variable
+
+```bash
+WEB3SIGNER_ETH2_GCP_PROJECT_ID=my-project
+```
+
+# Configuration file
+
+```bash
+eth2.gcp-project-id: "my-project"
+```
+
+<!--/tabs-->
+
+Globally unique identifier for the Google Cloud Platform (GCP) project where the
+secrets to be used by Web3Signer are stored.
+
+#### `gcp-secrets-enabled`
+
+<!--tabs-->
+
+# Syntax
+
+```bash
+--gcp-secrets-enabled=<BOOLEAN>
+```
+
+# Example
+
+```bash
+--gcp-secrets-enabled=true
+```
+
+# Environment variable
+
+```bash
+WEB3SIGNER_ETH2_GCP_SECRETS_ENABLED=true
+```
+
+# Configuration file
+
+```bash
+eth2.gcp-secrets-enabled: true
+```
+
+<!--/tabs-->
+
+Set to `true` to enable bulk loading from the GCP Secrets Manager service. The default is `false`. 
+
+#### `gcp-secrets-filter`
+
+<!--tabs-->
+
+# Syntax
+
+```bash
+--gcp-secrets-filter=<STRING>
+```
+
+# Example
+
+```bash
+--gcp-secrets-filter=my-secrets-filter
+```
+
+# Environment variable
+
+```bash
+WEB3SIGNER_ETH2_GCP_SECRETS_FILTER=my-secrets-filter
+```
+
+# Configuration file
+
+```bash
+eth2.gcp-secrets-filter: "my-secrets-filter"
+```
+
+<!--/tabs-->
+
+Use to filter secrets loaded into Web3Signer. [List operation filtering](https://cloud.google.com/secret-manager/docs/filtering) is applied
+
+Only secrets matching the filter are loaded. If not specified, all secrets from the project identified by
+[`--gcp-project-id`](#gcp-project-id) are loaded.
+
 #### `key-manager-api-enabled`
 
 <!--tabs-->

From 50c9b50580b624217c937ac11f729a1c640bbaa3 Mon Sep 17 00:00:00 2001
From: Alexandra Tran Carrillo
 <12214231+alexandratran@users.noreply.github.com>
Date: Fri, 1 Dec 2023 09:07:44 -0800
Subject: [PATCH 2/2] Update docs/reference/cli/subcommands.md

---
 docs/reference/cli/subcommands.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/reference/cli/subcommands.md b/docs/reference/cli/subcommands.md
index c4c4fdf..4c5165a 100644
--- a/docs/reference/cli/subcommands.md
+++ b/docs/reference/cli/subcommands.md
@@ -1549,7 +1549,7 @@ eth2.gcp-secrets-filter: "my-secrets-filter"
 
 <!--/tabs-->
 
-Use to filter secrets loaded into Web3Signer. [List operation filtering](https://cloud.google.com/secret-manager/docs/filtering) is applied
+Filter to use when loading secrets into Web3Signer. [List operation filtering](https://cloud.google.com/secret-manager/docs/filtering) is applied.
 
 Only secrets matching the filter are loaded. If not specified, all secrets from the project identified by
 [`--gcp-project-id`](#gcp-project-id) are loaded.