chore: use standard lib testing environment detection (#1631)

Author: ivokub

frontend/cs/commitment.go

@@ -4,16 +4,15 @@ import (
 	"crypto/rand"
 	"fmt"
 	"math/big"
-	"os"
-	"strings"
+	"testing"
 
 	"github.com/consensys/gnark/constraint/solver"
 	"github.com/consensys/gnark/debug"
 	"github.com/consensys/gnark/logger"
 )
 
 func Bsb22CommitmentComputePlaceholder(mod *big.Int, _ []*big.Int, output []*big.Int) (err error) {
-	if (len(os.Args) > 0 && (strings.HasSuffix(os.Args[0], ".test") || strings.HasSuffix(os.Args[0], ".test.exe"))) || debug.Debug {
+	if testing.Testing() || debug.Debug {
 		// usually we only run solver without prover during testing
 		log := logger.Logger()
 		log.Error().Msg("Augmented commitment hint not replaced. Proof will not be sound and verification will fail!")

logger/logger.go

@@ -6,7 +6,7 @@ package logger
 import (
 	"io"
 	"os"
-	"strings"
+	"testing"
 
 	"github.com/consensys/gnark/debug"
 	"github.com/rs/zerolog"
@@ -18,7 +18,7 @@ func init() {
 	output := zerolog.ConsoleWriter{Out: os.Stdout, TimeFormat: "15:04:05"}
 	logger = zerolog.New(output).With().Timestamp().Logger()
 
-	if !debug.Debug && strings.HasSuffix(os.Args[0], ".test") {
+	if !debug.Debug && testing.Testing() {
 		logger = zerolog.Nop()
 	}