-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize for mobile and clean up design #79
Conversation
seems that develop isn't a command
New intro, copy changes to debugger and links to repos added to footer
On desktop: 4 different left alignments - should these all be in the same general container / left alignment? Does this need padding around the text? Do we want to show QR next to blockie? This seems confusing. How can we update this table layout to not side scroll? Can we trim out some unnecessary info? The current date doesn't make much sense here since there isn't historical data - this table is only for your current session. Do we need my local time zone? Time zone offset? Do we need the full hash or can we use the shortened? I like the status pill. Can we update the color based on status? If it fails can we make red? On success green? On mobile in MetaMask app - can't click the connect button. This was fixed in the previous layout. The CTA button should always be visible without scrolling. Previously the button was fixed position to the bottom of the modal with the content area scrollable. See the implementation on the LowFunds modal for an example. Couldn't get past the Verify modal, I think something might have changed with MM that broke this. I thought it was working before. On mobile cipher browser - same issue with Connect button in modal. Seems like the modal content area is scrollable here and the button is fixed to the bottom but the positioning or something is off. Do ToastMessage icons not show up on mobile? Not obvious that this table is scrollable on mobile. Should we change the orientation of the data from left-right to top-bottom on mobile? |
I don't know if all of them need to be aligned with each other, but simplifying alignment of multiple elements would be cleaner.
Consistent padding would be good, e.g.
Agreed. Resizing one of these to establish a hierarchy would be good. FWIW, Dharma integrate the QR code & address like this: I don't know if you want to do that, but it's an alternative that could establish the blockie as the primary element in the hierarchy.
Anecdotally, I've seen a lot of apps use "table scrolling" at smaller viewports. We might consider this "best practices".
👍 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
No description provided.