Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommonAncestor should compare remote chain with non-canonical local chains too #9194

Open
tbenr opened this issue Mar 3, 2025 · 0 comments
Open

CommonAncestor should compare remote chain with non-canonical local chains too #9194

tbenr opened this issue Mar 3, 2025 · 0 comments

Comments

@tbenr
Copy link
Contributor

tbenr commented Mar 3, 2025 •
edited
Loading

when we compare remote chain to find a common ancestor in CommonAncestor, we only compare using our canonical head.
But if the chain we selected to sync to is non-canonical for us, we might have a lot of blocks on that chain that we are not considering, thus we end up redownloading them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbenr