Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActiveRecord 6.0 support #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Envek
Copy link

@Envek Envek commented Mar 26, 2020

Fixes #27

Tested in production, also there are tests in my fork here: https://github.com/Envek/graphql-preload

NickLaMuro added a commit to NickLaMuro/manageiq that referenced this pull request Nov 16, 2020
There is currently an outstanding PR for the graphql-preload to support
Rails 6:

  ConsultingMD/graphql-preload#32

So this is currently the simplest option available to us to support this
gem.
NickLaMuro added a commit to NickLaMuro/manageiq that referenced this pull request Nov 17, 2020
There is currently an outstanding PR for the graphql-preload to support
Rails 6:

  ConsultingMD/graphql-preload#32

So this is currently the simplest option available to us to support this
gem.
NickLaMuro added a commit to NickLaMuro/manageiq that referenced this pull request Nov 23, 2020
There is currently an outstanding PR for the graphql-preload to support
Rails 6:

  ConsultingMD/graphql-preload#32

So this is currently the simplest option available to us to support this
gem.
NickLaMuro added a commit to NickLaMuro/manageiq that referenced this pull request Nov 30, 2020
There is currently an outstanding PR for the graphql-preload to support
Rails 6:

  ConsultingMD/graphql-preload#32

So this is currently the simplest option available to us to support this
gem.
NickLaMuro added a commit to NickLaMuro/manageiq that referenced this pull request Dec 1, 2020
There is currently an outstanding PR for the graphql-preload to support
Rails 6:

  ConsultingMD/graphql-preload#32

So this is currently the simplest option available to us to support this
gem.
NickLaMuro added a commit to NickLaMuro/manageiq that referenced this pull request Dec 2, 2020
There is currently an outstanding PR for the graphql-preload to support
Rails 6:

  ConsultingMD/graphql-preload#32

So this is currently the simplest option available to us to support this
gem.
@robinboening
Copy link

robinboening commented Jan 22, 2021

Is there anything blocking you from merging this?

Tagging some people I believe having permissions to merge: @RoryO @wyattEpp @thiagofelix

Currently graphql-preload blocks me from upgrading my app to Rails 6.

@RoryO
Copy link
Contributor

RoryO commented Jan 22, 2021

I am sorry I have not been associated with this for over a year. @cobbr2 may be able to find someone to help.

@joeyparis
Copy link

@Envek (or @cobbr2)any chance we can get support for ActiveRecord 7.0 now?

@thiagofelix
Copy link
Contributor

I haven't work here for quite some time as well. Looking at the changes apparently we are changing considerably the library behavior so I am not sure if I can approve it confidently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rails 6 support
5 participants