Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login or sign up #145

Open
parteekcoder opened this issue Mar 10, 2023 · 3 comments
Open

Login or sign up #145

parteekcoder opened this issue Mar 10, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@parteekcoder
Copy link

Hey @pradeeban ,

In GSoC project 10, we allow users to upload their examples to github repository of concore, as we are thinking of the solution that not require user to have a github account but to keep track of users we should track their google account or something like that

Hence we should authenticate users with their google account or similar like that instead of github account which all users don't have

And we can also use that google account to differentiate and keep track of their PR from other users
So I would like to work upon this

@pradeeban
Copy link
Member

Hi @parteekcoder,
Good points.

You are thinking of a Single Sign-On with Google, I believe. As of now, we can keep track of the users in the contribute options (in theory, since the implementation is not complete yet) through the author name (which is a random string, actually), since you fixed that author name bug.

But having a Google sign-on could also help with the security aspect, as in OpenID, instead of the current API Key-based approach on FRI (which also is not complete yet).

Valid points to consider. We need to think a bit more about how this design will go and any caveats or road blocks. (What if one does not have a Google account. Not everyone has a Google account either).

@pradeeban pradeeban added the enhancement New feature or request label Mar 10, 2023
@parteekcoder
Copy link
Author

Hi @parteekcoder, Good points.

You are thinking of a Single Sign-On with Google, I believe. As of now, we can keep track of the users in the contribute options (in theory, since the implementation is not complete yet) through the author name (which is a random string, actually), since you fixed that author name bug.

But having a Google sign-on could also help with the security aspect, as in OpenID, instead of the current API Key-based approach on FRI (which also is not complete yet).

Valid points to consider. We need to think a bit more about how this design will go and any caveats or road blocks. (What if one does not have a Google account. Not everyone has a Google account either).

yeah I will shortly send you my approch to handle this

@pradeeban
Copy link
Member

Sounds good. We can discuss the approach further (either here or in your proposal draft).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants