Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected exception getting Belief: Message too long #490

Open
helins opened this issue Jul 4, 2023 · 5 comments
Open

Unexpected exception getting Belief: Message too long #490

helins opened this issue Jul 4, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@helins
Copy link
Member

helins commented Jul 4, 2023

It seems all peers issue that pair of warnings very early in simulations, once.

["2023-07-03T11:37:36.944" :warn [convex.net.message.Message 104] ["Bad format in Message payload" {:trace [[convex.core.data.Format decodeMultiCell "Format.java" 738] [convex.net.message.Message getPayload "Message.java" 102] [convex.peer.BeliefPropagator mergeBeliefMessage "BeliefPropagator.java" 297] [convex.peer.BeliefPropagator awaitBelief "BeliefPropagator.java" 280] [convex.peer.BeliefPropagator loop "BeliefPropagator.java" 132] [convex.peer.AThreadedComponent$ComponentTask run "AThreadedComponent.java" 29] [java.lang.Thread run "Thread.java" 833]],:message "Message too long: 10973268",:exception convex.core.exceptions.BadFormatException}]]
["2023-07-03T11:37:36.946" :warn [convex.peer.BeliefPropagator 349] ["Unexpected exception getting Belief" {:trace [[convex.core.data.Format decodeMultiCell "Format.java" 738] [convex.net.message.Message getPayload "Message.java" 102] [convex.peer.BeliefPropagator mergeBeliefMessage "BeliefPropagator.java" 297] [convex.peer.BeliefPropagator awaitBelief "BeliefPropagator.java" 280] [convex.peer.BeliefPropagator loop "BeliefPropagator.java" 132] [convex.peer.AThreadedComponent$ComponentTask run "AThreadedComponent.java" 29] [java.lang.Thread run "Thread.java" 833]],:message "Message too long: 10973268",:exception convex.core.exceptions.BadFormatException}]]
@mikera
Copy link
Member

mikera commented Jul 4, 2023

Is your genesis state particularly large?

@mikera mikera self-assigned this Jul 4, 2023
@mikera
Copy link
Member

mikera commented Jul 4, 2023

Solutions:
A) Increase message size limitation
B) Add debugging code to see what message is causing this

@helins
Copy link
Member Author

helins commented Jul 7, 2023

Still present as of today

@helins
Copy link
Member Author

helins commented Jul 11, 2023

Might be resolved.
It didn't show up while doing 7 full runs against 80589055.

@mikera
Copy link
Member

mikera commented Jul 13, 2023

Glad it is working. I bumped max message size somewhat to make it easier. Longer term fix is to selectively prune messages that risk being too big (though this might cause partial beliefs / temporarily reconciliation delays)

@mikera mikera added the enhancement New feature or request label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants