Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plume-db & plume-db-querydsl] Provide interfaces for TransactionManager #18

Closed
amanteaux opened this issue Sep 29, 2022 · 1 comment
Closed
Milestone

Comments

@amanteaux
Copy link
Member

This will enable to provide an easier way to override the TransactionManager.

The current TransactionManager will be called HikariTransactionManager, whereas the interface will still provide default implementation of executeAndReturn and execute based on the implementation of dataSource.

This will impact TransactionManagerQuerydsl:

  • It will implement TransactionManager instead of extending it
  • It will contain an instance of TransactionManager to delegate the corresponding methods
@amanteaux amanteaux added this to the 5.0.0 milestone Sep 29, 2022
@amanteaux
Copy link
Member Author

Implemented in #35 where the TransactionManager now depends only on the DataSource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant