Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures with Python 3.12 #581

Closed
sebix opened this issue Feb 5, 2024 · 9 comments
Closed

Test failures with Python 3.12 #581

sebix opened this issue Feb 5, 2024 · 9 comments

Comments

@sebix
Copy link

sebix commented Feb 5, 2024

[   36s] =================================== FAILURES ===================================
[   36s] ______________ TestResource.test_explicit_collection_service_name ______________
[   36s] 
[   36s] self = <tests.test_resource.TestResource testMethod=test_explicit_collection_service_name>
[   36s] 
[   36s]     def test_explicit_collection_service_name(self):
[   36s]         route_url = testing.DummyRequest().route_url
[   36s]         # service must exist
[   36s] >       self.assert_(route_url('collection_user_service'))
[   36s] E       AttributeError: 'TestResource' object has no attribute 'assert_'. Did you mean: 'assertIn'?
[   36s] 
[   36s] tests/test_resource.py:186: AttributeError
[   36s] ___________________ TestResource.test_explicit_service_name ____________________
[   36s] 
[   36s] self = <tests.test_resource.TestResource testMethod=test_explicit_service_name>
[   36s] 
[   36s]     def test_explicit_service_name(self):
[   36s]         route_url = testing.DummyRequest().route_url
[   36s] >       self.assert_(route_url('user_service', id=42))  # service must exist
[   36s] E       AttributeError: 'TestResource' object has no attribute 'assert_'. Did you mean: 'assertIn'?
[   36s] 
[   36s] tests/test_resource.py:190: AttributeError
@leplatrem
Copy link
Contributor

What branch / commit are you using? It looks like it precedes 61e209d

@sebix
Copy link
Author

sebix commented Feb 8, 2024

Using the latest release 6.0.1. I will add that commit as patch and report back

@Natim
Copy link
Contributor

Natim commented Feb 8, 2024

Thank you @sebix we will review it 🙏

@leplatrem
Copy link
Contributor

Latest release is old, and does not contain the commit I mentioned.

Let's merge #582 and tag a new release

@sebix
Copy link
Author

sebix commented Feb 8, 2024

A recent release is appreciated.

leplatrem added a commit that referenced this issue Feb 8, 2024
@sebix
Copy link
Author

sebix commented Feb 8, 2024

With the patch applied, the tests work fine. The package in openSUSE is updated

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Feb 8, 2024
@leplatrem
Copy link
Contributor

@sebix do you use Cornice as a package in OpenSuse? Are there many projects/packages depending on it?

@sebix
Copy link
Author

sebix commented Feb 13, 2024

@sebix do you use Cornice as a package in OpenSuse?

I maintain the package

Are there many projects/packages depending on it?

None at the moment, as far as I can see.

@leplatrem
Copy link
Contributor

I'm not sure how relevant it is to package it in a Linux distribution.
My intuition is that it is very likely that projects building on top of Cornice would manage their dependencies locally instead of relying on system packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants