Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the item page of the storage docs #82

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Rewrite the item page of the storage docs #82

merged 5 commits into from
Jul 16, 2024

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Jun 28, 2024

Closes #50

@aumetra aumetra requested a review from uint June 28, 2024 20:07
@vercel Vercel
Copy link

vercel bot commented Jun 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmwasm-docs ✅ Ready (Inspect) Visit Preview ✅ 5 resolved Jul 16, 2024 1:08pm

@aumetra aumetra marked this pull request as draft June 28, 2024 20:08
@aumetra
Copy link
Member Author

aumetra commented Jun 28, 2024

This is still very barebones and might need some more examples. Most I did for now was reword the entire "chapter" and change the formatting

@aumetra aumetra marked this pull request as ready for review July 15, 2024 09:33
hashedone
hashedone reviewed Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments in vercel

@aumetra aumetra requested a review from hashedone July 15, 2024 10:13
uint
uint approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@uint uint left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the main change is explaining the fact an Item might be "empty" more clearly? Sounds good.

I'd still keep the link to the API ref around, or mention an item might be removed (missed that it's there already).

@aumetra
Copy link
Member Author

aumetra commented Jul 16, 2024

Looks like the main change is explaining the fact an Item might be "empty" more clearly? Sounds good.

Yeah, that and some miscellaneous wording changes, and structuring the page a bit differently. Otherwise I haven't seen any other things that might need changing.

@aumetra aumetra merged commit b1d0b1e into main Jul 16, 2024
4 checks passed
@aumetra aumetra deleted the aw/rewrite-item branch July 16, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uint uint uint approved these changes

@hashedone hashedone Awaiting requested review from hashedone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite Item
3 participants
@aumetra @uint @hashedone