Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gems use c:names tag instead of c:name_gems #57

Open
lukebemish opened this issue May 4, 2020 · 0 comments
Open

Gems use c:names tag instead of c:name_gems #57

lukebemish opened this issue May 4, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@lukebemish
Copy link

Is your feature request related to a problem? Please describe.
As the title says. This breaks compatibility with mods that use the c:name_gems format, such as Tech Reborn.

Describe the solution you'd like
I'm not sure if other mods are currently using the c:name format, but I think a good solution here would be to either use both tags, switch to the c:name_gems format, or nest one inside the other

Describe alternatives you've considered
As mentioned in TechReborn/TechReborn#2106, it looks like the best bet here is probably to change this on the Cotton Resources side, to stick with a relatively commonly used convention. That said, I am not sure if the c:name format is used often, so this is by no means necessarily a perfect measure. To keep compatibility, the items could be added to both tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant