Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect test for max_session_duration_in_seconds? #174

Open
matthewchao opened this issue Jul 18, 2022 · 0 comments
Open

incorrect test for max_session_duration_in_seconds? #174

matthewchao opened this issue Jul 18, 2022 · 0 comments

Comments

@matthewchao
Copy link

In

const testAccCheckAlksIamRoleConfigUpdateNoMaxDuration = `
resource "alks_iamrole" "foo" {
name = "bar430"
type = "Amazon EC2"
include_default_policies = false
enable_alks_access = true
max_session_duration_in_seconds = 3600
}

the variable name indicates that perhaps no max_session_duration_in_seconds should be provided. I think the test at

resource.TestCheckResourceAttr(
"alks_iamrole.foo", "max_session_duration_in_seconds", "3600"),
was supposed to check for a default value, but as written, the test is no different from the one at
resource.TestCheckResourceAttr(
"alks_iamrole.foo", "max_session_duration_in_seconds", "3600"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant