Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge put_bytes into develop #519

Open
rickybalin opened this issue Oct 29, 2024 · 4 comments
Open

Merge put_bytes into develop #519

rickybalin opened this issue Oct 29, 2024 · 4 comments
Labels
type: feature Issues that include feature request or feature idea

Comments

@rickybalin
Copy link

Description

Some time ago you added a feature to SmartRedis to add a byte string array to the Orchestrator. This feature was added in a branch called put_bytes. Would it be possible to merge this feature into the develop branch?

Justification

This feature is very useful for sharing AI/ML model checkpoints between workflow components across the Orchestrator. Models can be serialized, with something like torch.jit.trace, and then stored in the Orchestrator to then be loaded and run from various components. This is helpful when models are not supported by RedisAI, such as GNNs.

@rickybalin rickybalin added the type: feature Issues that include feature request or feature idea label Oct 29, 2024
@mellis13
Copy link
Collaborator

Thanks for posting this, @rickybalin -- we can definitely do that. Do you need an initial implementation in all clients or just a subset?

@rickybalin
Copy link
Author

Just Python for the current application, but likely all clients will be useful (maybe with a priority on the C++ client over C and Fortran). Thanks!

@mellis13
Copy link
Collaborator

mellis13 commented Nov 4, 2024

C++ and Python APIs have been merged into develop. We will follow-up with C and Fortran interfaces later. Please let us know if you have any feedback/issues with it!

@rickybalin
Copy link
Author

Thanks, no issues so far with the Python API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Issues that include feature request or feature idea
Projects
None yet
Development

No branches or pull requests

2 participants