From 18fe50aa7edce032c8c47a68975e46a9663d6457 Mon Sep 17 00:00:00 2001
From: Matt Drozt <drozt@hpe.com>
Date: Wed, 7 Feb 2024 13:25:40 -0800
Subject: [PATCH] Patch Changes for Release Prep (#477)

This PR makes several patch changes to prepare for a SmartSim release
including:

- Set the default value of the "enable telemetry" flag to on.
Currently this will enable telemetry system wide until finer grain
control can be established with #460
- Bump the output `manifest.json` version number to match that of
`smartdashboard`
- Pin a watchdog version to avoid build errors


[ committed by @MattToast @ankona ]
[ reviewed by @ankona ]

---------

Co-authored-by: Christopher McBride <christopher.mcbride@gmail.com>
---
 setup.py                          | 2 +-
 smartsim/_core/config/config.py   | 2 +-
 smartsim/_core/utils/serialize.py | 2 +-
 tests/test_config.py              | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/setup.py b/setup.py
index 58d35e4a6..dd91d444a 100644
--- a/setup.py
+++ b/setup.py
@@ -167,7 +167,7 @@ def has_ext_modules(_placeholder):
     "tqdm>=4.50.2",
     "filelock>=3.4.2",
     "protobuf~=3.20",
-    "watchdog>=3.0.0",
+    "watchdog>=3.0.0,<4.0.0",
 ]
 
 # Add SmartRedis at specific version
diff --git a/smartsim/_core/config/config.py b/smartsim/_core/config/config.py
index d812a0765..832790116 100644
--- a/smartsim/_core/config/config.py
+++ b/smartsim/_core/config/config.py
@@ -225,7 +225,7 @@ def telemetry_frequency(self) -> int:
 
     @property
     def telemetry_enabled(self) -> bool:
-        return int(os.environ.get("SMARTSIM_FLAG_TELEMETRY", "0")) > 0
+        return int(os.environ.get("SMARTSIM_FLAG_TELEMETRY", "1")) > 0
 
     @property
     def telemetry_cooldown(self) -> int:
diff --git a/smartsim/_core/utils/serialize.py b/smartsim/_core/utils/serialize.py
index a84e703ec..7bbfebe91 100644
--- a/smartsim/_core/utils/serialize.py
+++ b/smartsim/_core/utils/serialize.py
@@ -82,7 +82,7 @@ def save_launch_manifest(manifest: _Manifest[TStepLaunchMetaData]) -> None:
         manifest_dict = {
             "schema info": {
                 "schema_name": "entity manifest",
-                "version": "0.0.2",
+                "version": "0.0.3",
             },
             "experiment": {
                 "name": manifest.metadata.exp_name,
diff --git a/tests/test_config.py b/tests/test_config.py
index bbbb54526..b9577dba2 100644
--- a/tests/test_config.py
+++ b/tests/test_config.py
@@ -205,7 +205,7 @@ def test_redis_cli():
         pytest.param("0", False, id="letter zero"),
         pytest.param("1", True, id="letter one"),
         pytest.param("-1", False, id="letter negative one"),
-        pytest.param(None, False, id="not in env"),
+        pytest.param(None, True, id="not in env"),
     ],
 )
 def test_telemetry_flag(