From 6dea58289c9d02678a96c5b43fdb265526a1df1d Mon Sep 17 00:00:00 2001 From: Matt Drozt Date: Mon, 18 Mar 2024 14:46:08 -0700 Subject: [PATCH] Remove duplicate launched model names from full test suite (#520) Removes behavior deprecated in #480 from test suite. [ committed by @MattToast ] [ reviewed by @mellis13 ] --- doc/changelog.rst | 10 +++++++--- tests/full_wlm/test_mpmd.py | 4 +++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/doc/changelog.rst b/doc/changelog.rst index d96b361ea..58d1efa33 100644 --- a/doc/changelog.rst +++ b/doc/changelog.rst @@ -26,6 +26,7 @@ Description - Update the version of Redis from `7.0.4` to `7.2.4` - Fix publishing of development docs - Update Experiment API typing +- Minor enhancements to test suite Detailed Notes @@ -48,15 +49,18 @@ Detailed Notes software and files that come from the default Github Ubuntu container. (SmartSim-PR504_) - Update the generic `t.Any` typehints in Experiment API. (SmartSim-PR501_) +- Remove previously deprecated behavior present in test suite on machines with + Slurm and Open MPI. (SmartSim-PR520_) -.. _SmartSim-PR517: https://github.com/CrayLabs/SmartSim/pull/517 -.. _SmartSim-PR512: https://github.com/CrayLabs/SmartSim/pull/512 +.. _SmartSim-PR520: https://github.com/CrayLabs/SmartSim/pull/520 .. _SmartSim-PR518: https://github.com/CrayLabs/SmartSim/pull/518 +.. _SmartSim-PR517: https://github.com/CrayLabs/SmartSim/pull/517 .. _SmartSim-PR514: https://github.com/CrayLabs/SmartSim/pull/514 -.. _SmartSim-PR463: https://github.com/CrayLabs/SmartSim/pull/463 +.. _SmartSim-PR512: https://github.com/CrayLabs/SmartSim/pull/512 .. _SmartSim-PR507: https://github.com/CrayLabs/SmartSim/pull/507 .. _SmartSim-PR504: https://github.com/CrayLabs/SmartSim/pull/504 .. _SmartSim-PR501: https://github.com/CrayLabs/SmartSim/pull/501 +.. _SmartSim-PR463: https://github.com/CrayLabs/SmartSim/pull/463 0.6.2 diff --git a/tests/full_wlm/test_mpmd.py b/tests/full_wlm/test_mpmd.py index 96497c760..0167a8f08 100644 --- a/tests/full_wlm/test_mpmd.py +++ b/tests/full_wlm/test_mpmd.py @@ -87,7 +87,9 @@ def prune_commands(launcher): settings.make_mpmd(deepcopy(settings)) settings.make_mpmd(deepcopy(settings)) - mpmd_model = exp.create_model("mmpd", path=test_dir, run_settings=settings) + mpmd_model = exp.create_model( + f"mpmd-{run_command}", path=test_dir, run_settings=settings + ) exp.start(mpmd_model, block=True) statuses = exp.get_status(mpmd_model) assert all([stat == SmartSimStatus.STATUS_COMPLETED for stat in statuses])