Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backtank crashing on ctrl+pick block #7284

Merged

Conversation

VoidLeech
Copy link
Contributor

Issues Fixed

Fixes #7281

Implemented Solution

  • Copy vanilla/forgecaps compoundtags before adding them to the cloneitemstack. With ctrl+pick block, they end up in the BlockEntityTag that gets tacked onto the itemstack's tag. Which was vanillaTag and so vanillaTag now contained a reference to itself. This is all that's strictly necessary to fix the linked issue.
  • Copy the tags on placement too so every backtank placed from the same stack has its own copy instead of sharing the tags.
  • And throw out BlockEntityTag so it can't repeatedly nest and cause the same issue but then via recursion depth. It didn't meaningfully retain anything in that tag that wasn't in vanillaTag/forgeCaps anyhow when placed.

@IThundxr
Copy link
Member

Thanks!

@IThundxr IThundxr merged commit 0870d34 into Creators-of-Create:mc1.20.1/dev Jan 12, 2025
@VoidLeech VoidLeech deleted the mc1.20.1/backtank-overflow branch January 12, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netherite backtank crashes the game and corrupts the chunk
2 participants