Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Albedo does support arbitrary message signing #5

Open
kalepail opened this issue Oct 26, 2023 · 3 comments
Open

Albedo does support arbitrary message signing #5

kalepail opened this issue Oct 26, 2023 · 3 comments

Comments

@kalepail
Copy link

When trying to sign blob I'm getting this error when using Albedo:
Error: Albedo does not support signing arbitrary blobs

This isn't true:
https://github.com/stellar-expert/albedo/tree/master/intent#intent-sign_message---sign-text-message

@earrietadev
Copy link
Contributor

If I'm not wrong that feature from Albedo has a different goal, that function edits the original input in order to avoid someone signing something dangerous: https://github.com/stellar-expert/albedo/blob/fae9b3284ce0346debb96f63b33a96e324692523/frontend/src/actions/action-authentication-context.js#L60C62-L60C62

While the one from Freighter signs the original blob directly.

What we could add is the compatibility for message signing for those wallets who allows it (I think currently Albedo is the only one but not fully sure)

@emarai
Copy link

emarai commented Jan 9, 2024

@earrietadev hey I'm looking for a way to prove account ownership. I think that albedo signing message that you mentioned would work. what do you think? I'm quite new in the space, so do you have any other idea to accomplish this? (saw this stale discussion btw stellar-deprecated/stellar-client#595)

@earrietadev
Copy link
Contributor

@emarai For validating account ownership, I suggest using SEP-10: https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0010.md

That's the most used method across the stellar ecosystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@kalepail @earrietadev @emarai and others