From 03a7e0de1248cd3c27b7f685b2a8b4c550ef9280 Mon Sep 17 00:00:00 2001 From: Larry Garfield Date: Wed, 25 Sep 2024 08:54:23 -0500 Subject: [PATCH 1/3] Test on GHA on PHP 8.4 --- .github/workflows/quality-assurance.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/quality-assurance.yaml b/.github/workflows/quality-assurance.yaml index dd958f1..0368476 100644 --- a/.github/workflows/quality-assurance.yaml +++ b/.github/workflows/quality-assurance.yaml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - php: [ '8.1', '8.2', '8.3' ] + php: [ '8.1', '8.2', '8.3', '8.4' ] composer-flags: [ '' ] phpunit-flags: [ '--coverage-text' ] steps: @@ -28,7 +28,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - php: [ '8.1', '8.2', '8.3' ] + php: [ '8.1', '8.2', '8.3', '8.4' ] composer-flags: [ '' ] steps: - uses: actions/checkout@v2 From ede4812451ab5c14110dadfa034c0df89e2fe270 Mon Sep 17 00:00:00 2001 From: Larry Garfield Date: Wed, 25 Sep 2024 08:58:12 -0500 Subject: [PATCH 2/3] Update PHPStan config. --- phpstan.neon | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/phpstan.neon b/phpstan.neon index 0865407..0ead9cd 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -3,8 +3,9 @@ parameters: paths: - src - tests - checkGenericClassInNonGenericObjectType: false ignoreErrors: + - + identifier: missingType.generics - message: '#type has no value type specified in iterable type array#' path: tests/ From f3506c6fbedf6340327ae622d340dc15b3d79982 Mon Sep 17 00:00:00 2001 From: Larry Garfield Date: Wed, 25 Sep 2024 08:58:22 -0500 Subject: [PATCH 3/3] Add missing type in mock. --- tests/Fakes/MockLogger.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Fakes/MockLogger.php b/tests/Fakes/MockLogger.php index f4ca2b5..3b464d3 100644 --- a/tests/Fakes/MockLogger.php +++ b/tests/Fakes/MockLogger.php @@ -17,7 +17,7 @@ class MockLogger extends AbstractLogger /** * @param array $context */ - public function log($level, $message, array $context = []): void + public function log($level, string|\Stringable $message, array $context = []): void { $this->messages[$level][] = [ 'message' => $message,