Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Crystals/Currency By #300

Open
burghenby opened this issue Jan 26, 2025 · 1 comment
Open

Group Crystals/Currency By #300

burghenby opened this issue Jan 26, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@burghenby
Copy link

Describe the bug
"Group Crystals By" and "Group Currency By" are no longer separating these specific items into their own groups in the craft lists. By default under "Default Configuration" these are each listed as "Separate" in the group-down (indicated by white text instead of green). Previously I was seeing these separated as I was able to immediately minimize these sections on my lists as I had no need to track them. However, upon getting my partner set up with this plugin I discovered both on their side and mine that the crystals and currency are collected in the "Gather/Buy" section with everything else. The "Currency" section contains items that are only purchasable with currency (seals and the like).

To Reproduce
Steps to reproduce the behavior:
This will be difficult as I have not changed my settings recently to prompt this change but...

  1. Default settings is "separate" which previously listed crystals and currency (gill, seals, ventures, etc) in separate categories that could be minimized if I didn't want to look at them.
  2. Switched settings to "together" to see if code got mucked and if this would fix it. Did not fix present lists that previously displayed separate behavior.
  3. Created new list with "together" settings. Did not display "separate" behavior with crystals and currency.
  4. Returned to default "separate" setting. Created new list. Did not display "separate" behavior for crystals and currency.

Expected behavior
Under "Default Configuration" it clearly asks "Should the currency/crystals be groups together or show up in the Gather/Buy list?" The options are "Separate" or "Together." This is a clear question with clear options provided. I would expect "Separate" to keep the Crystals in their own "Crystal" section and Currencies in their own "Currency" section. This is the behavior that was displayed previously, so I'm not sure if there was simply a recent update that mucked something up or what.

Screenshots
Settings of Crystal and Currency "group by" set as "separate" which is the default, example of non-default settings also pictured (white text versus green text)
Image

A previously-created craft list that used to list crystals and currency in separate sections, now listing crystals and currency under the header of "Gather/Buy"
Image

A different list from the one above that that has a "Currency" section but is using it for items that require currency for purchasing instead of the the previous behavior of listing the total currency needed for said purchasing. This list was also created previously; All of these items used to be listed under "Gather/Buy."
Image

Dalamud Information:
Yes? The "Get plugin testing builds" option is selected, so I assume that is what you refer to.

Filter Issues
This is a setting, not a filter... but if I am mistaken let me know cause I'm a little confused on the whole export thing with this tool.

Additional context
Ah... none that I can think of. Love the tool!

@burghenby burghenby added the bug Something isn't working label Jan 26, 2025
@github-project-automation github-project-automation bot moved this to Awaiting Development in Allagan Tools Jan 26, 2025
@burghenby
Copy link
Author

burghenby commented Jan 26, 2025

blinks at Github I dunno if I'd consider this "critical" really... Annoying, but not really critical. XD

EDIT: I just now realized that "critical" is the username, not the level of impact XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Awaiting Development
Development

No branches or pull requests

2 participants