Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housing sources not appearing in inventories tab #301

Open
Seamooo opened this issue Jan 31, 2025 · 0 comments
Open

Housing sources not appearing in inventories tab #301

Seamooo opened this issue Jan 31, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Seamooo
Copy link

Seamooo commented Jan 31, 2025

Describe the bug
When selecting all houses or specific housing inventories, they did not display in the craft list filter configuration section prefixed with "Housing Sources: "
They do however, still apply correctly to the list, as such I believe this to be localised to the section generating the text to display.

To Reproduce
Steps to reproduce the behavior:

  1. Create a craft list
  2. Populate it with at least one item that exists in your house's storage
  3. Edit the craft list's configuration
  4. In the Settings tab, change Retainer Retrieval (Output) to Yes
  5. In the Inventories tab, under the Sources section set the Source - All Houses? option to yes, and/or under Source - Inventories select your housing inventory that the item exists in
  6. Scrolling down, observe that no housing inventory is listed to the right of "Housing Sources: "
  7. Accepting this configuration, observe that the item added to the list is shown as retrievable from the housing source

Expected behavior
The "Housing Sources" section is populated with the selected inventories, or all houses depending on what was selected

Screenshots

Current behaviour:

Image

Expected behaviour (produced by removing check for key starting with "9"):

Image

Dalamud Information:
Do you have testing enabled?

No

Filter Issues

below is an example filter config for the craft list

H4sIAAAAAAAACtVb62/buhXH/hV9zgY+RTHf0iRdgrU3t3W7brfYB4qiYqGy5KtHuqzo/75DPWzLljyAsHU9BIHjcyjyd8jzFvOnH94nFabmMfKuvcAQw5GvsKKaoZjJCEdEIhSoSBnGYu/Kuy1UXG2fkBQLhXxfh0wxEWgVas0iiiMZoQhhCU88JM/LFH6r93lkvGsEc9SFqkz0WJlV6V1ndZpeeYu8LrR5zF5MVuVFYoDx9V9Xnh3zObmF4c958WqX7KkLowq93Ofc/14n60WaV/uMBvKDsTi8a8J2BTmgPhgVmeI2TwGTd/3D+weg/gvg/qf9ZFReeb9519hSvjSfPztEeXGw7J0pqyRTVZJnh7KVD7/34j+WsFxqdJUAoC3xfr00K1OotMH1LikBZqzS0lx5v6gVDPSqsv5W/3mp6hK2+q5ep4kGCOVTlr7207xN0soUzW4/Zh9NpZLMFJuNH+feZ/UKZIMpk3KdqtfHDLaq3Cz+tDbZTfklyaL8+4b4oVZZlVSwrgdYHt+ZF5O2fy/WSZFUYZ5F7XeLvV23/d7+/el1DRIFV97fjJ0jjlQUBKGmVMXMj5EMpU+1lqBvUmocer3S3KTpgVQbzkNel3bDO4wb+tvCmNt8tVZZcx5VUZsdVf2yNBlAuEm/q1e7sZ9L8/SxRZlkzweL3C5VoXS1s/7OuY/BG7L3sIwN6cUYGotO68jcFnlZbhBsJB1o3rGBdvX/wPppvcq2WtESrdbtcXbm7ZQ92Qe2S//Khlawt1vtvi+W+Xph0hT29tci0VavvZb6pn4dEt+r4pupbl7AKJ7NAf1TXqn0kHmrsjfmTV43Zt7b1s2LSlJr/zfVp2Rlol8a99Ryn77DaVkbBht/1HnW0zcKYp1DMbIl4wP687cGPGCAUY0/YZ1FUW14O0rXcsaWPBi0O/sOc0PbmeQY7361tkbdzfyc5YV5+GAtxDq8nXk3PurOxKpOt65qkazWaatMMLwNA7v68iUv0mhHwZqnG2/aqN4I46kABz1Yt/NT2xjTa+3XH3DWd0lhRejwtLzOgdrj7dbpPQ8NlSFhGHOEfEb8QAqhDfcF0RAXObVhsH24Xf/+32uAtEtZVNZNLExl5QUMPyBCfE6yakixPvcxi3Pr93pSFyNe2+i20HnH+nn1P8SwH3tiEF8baaiWkmAWIRUQ3/hGMwmBHQf4IsVozvJmlddZtbHPPbEQRzrWMZGRHzOBSIANjgniWIcBQty/RLH60LgnihRxwEjsI4Yww5EOQNGw4VEkQkjEYnmJonQufigIk0GkdaREJBhTIgg4IYxzGkZc0YhfpKq9y3UbxYai8EhyElHGKAf1Ck0QRoxxzZFhkBRj/UeIAiF0GIodnFqgdMipQkwTyrREYWCwMZCqU4G0xOr/xKlRqSiNhUEx1Cc+40Hoo0CgmDCpJNbBhTu1jwYKlMJE+z4Na4wwpTRiAQN/pniMmVKCGapAOnaxUvXz7zs2HxwYuGSmTcgw+GjfMCN9hELEuGTicuVpU5WhNCq0pS3yka99Bk4hwBSROCZG+SFSmFyiNG0+/CZXRfQ+yZpceF/nhI5iFEUR5gGDSKSoFIbhOGZBLKNQXL5UTbY/JpoIkRZxKLQPmQ+zZxTHXChoUxjfjxi6RNFuNHiGMrERqSvvwIfv25WOIVPgnEP+Y5gNrmFks7lQIKiNVdNu+SOC05s8T43K2gLZUltjavL65nygfr6B3sZLm+r3Zd/hoC7FL6dHPOSr3UkAWVM3bZf+2Qs5ID1mUJKa4bA7o5OVSgc0uxcHhNtlDosPyWmePY/Q26VHGDsNnB/bL5tyxfZ/rOeBtthGPR4SqNk76obYl5LwCQX2i+kqIVvx2En32AoaMJOsp7pa11XfkStMpl//WuT1utOF7snXEozsgP5rYbSddMggoHJQeL5WS/h6D3iHbGgn9bAPJmwaHH830FAqdsktxkbIrd62D3zoY+nWntocqdkxMKPt5mbPMCwB/QXYsbGSGqva3d7ZZAoUHnvXvFV90lpLY7ItA5CPM0DicQadYkB/a5zBJhef5ljhxjmT6+NJyHLykUnxxYZBoAs6RsbjZDJODsbJHEs5yqFUYjrxDEFo8hm2w/EnxZ5UBzFkgAfc+qitirVd3t/ybIfWq1yf0Xc9cFDBt6my7hdO9CP4pXXTXsfSt4dStlZgx/aO8delKjdO/c6sq2Wr6dZxw4MCBVasDMKJSvvi81O+qHL97Valuk5tA/6gc9uNaKbqaVsra85sDCYREjvBxOQcOBuVG93OIBBOOH2/OYfTwmRTMDn1uRNMynnz5EzHzkTjfxxwUtCY+XBSQd1wEiQYmhEnkdJ3A0o4n1FBCZLUzS1BljqfuZMgcPOemMPPjDgldnNLmEtxBjfPJw2e08BNPwV0AObbUEevxLkgpwfJjkQj4hqN2MlxBtPGbl94Oxl7wOZznsjZ0i8epJBiRm/EGWVu9iMoF5du5PC2qBFvLiN3RAmv5/B8aomF75Z3+NzemTkxTDrtMH1Xh0nFnOlmsylO6eYZdLMtzE+om4DyDGFy8tQZvHh3NvUzVBlH0nfmihTRppKaSUEhi3PPkE5fX8ojdTB2roNP7z6PaGgTn1009ByOyT+CkzjjDE6Okx+pgx0LN1sHo/lSENhQ6ryhcr4NhZSOuqZ0/un3k05GJBw0bQynCD9jIsL8Rssc9hPBy/DT6+epIzxU6zO6TwhHzm7+DF2vabckiGP6ydmc3STsuzVpoMqUM5aZ1BGmTULEnL1O6ly18/mMiCDi2qUR7OI7c5RcfpcGYuUZvOap2x84OEMmh0+/k+TiQRJC8XzBxx3kGfK3yQhJEXKshAg/wxvWIz3OJiK7JcRnwDlZslE4P7fWHBbyDD5zckcpQY49ROzDfcrT6+ipHScN5Bl80nSyGbhaEoNbt6ffzummgkCOtSUlTbvstEDFkZqNuPpQcoZ3l0e6c8K9O4fney9I4f2es4bOmCgx37Fso4gGfMZiHYKSc750hmsVzF5rG7s5uXuh9eBOace0l94svIOnLAP+p3OU/j4Px8fDNe9s4pEka/49dI/VXhO3ALp7edsreUN2c2PvCa6sFnDXdiCXPZWDebd3Trs73V53nw8i+H8BlAs4+Uk/AAA=

Additional context
I am on the materia DC, in case this has an effect on the keys produced for houses.
Doing some digging through the ui text generation, I found the two keys that were produced by InventoryTools.Lists.ListCategoryService.SourceHouseCategories to be 160722211707421184 and 1021191215511896566. Neither of these keys begin with 9 and as such the check below fails for both.

characterCategories.Key.ToString().StartsWith("9"))

I also noticed there is no such check in InventoryTools.Logic.Filters.DestinationsFilter so assume that this solved a problem in the past that's no longer a problem.
Removing this line produced the expected text.

@Seamooo Seamooo added the bug Something isn't working label Jan 31, 2025
@github-project-automation github-project-automation bot moved this to Awaiting Development in Allagan Tools Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Awaiting Development
Development

No branches or pull requests

2 participants