You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When selecting all houses or specific housing inventories, they did not display in the craft list filter configuration section prefixed with "Housing Sources: "
They do however, still apply correctly to the list, as such I believe this to be localised to the section generating the text to display.
To Reproduce
Steps to reproduce the behavior:
Create a craft list
Populate it with at least one item that exists in your house's storage
Edit the craft list's configuration
In the Settings tab, change Retainer Retrieval (Output) to Yes
In the Inventories tab, under the Sources section set the Source - All Houses? option to yes, and/or under Source - Inventories select your housing inventory that the item exists in
Scrolling down, observe that no housing inventory is listed to the right of "Housing Sources: "
Accepting this configuration, observe that the item added to the list is shown as retrievable from the housing source
Expected behavior
The "Housing Sources" section is populated with the selected inventories, or all houses depending on what was selected
Screenshots
Current behaviour:
Expected behaviour (produced by removing check for key starting with "9"):
Dalamud Information:
Do you have testing enabled?
No
Filter Issues
below is an example filter config for the craft list
Additional context
I am on the materia DC, in case this has an effect on the keys produced for houses.
Doing some digging through the ui text generation, I found the two keys that were produced by InventoryTools.Lists.ListCategoryService.SourceHouseCategories to be 160722211707421184 and 1021191215511896566. Neither of these keys begin with 9 and as such the check below fails for both.
I also noticed there is no such check in InventoryTools.Logic.Filters.DestinationsFilter so assume that this solved a problem in the past that's no longer a problem.
Removing this line produced the expected text.
The text was updated successfully, but these errors were encountered:
Describe the bug
When selecting all houses or specific housing inventories, they did not display in the craft list filter configuration section prefixed with "Housing Sources: "
They do however, still apply correctly to the list, as such I believe this to be localised to the section generating the text to display.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The "Housing Sources" section is populated with the selected inventories, or all houses depending on what was selected
Screenshots
Current behaviour:
Expected behaviour (produced by removing check for key starting with "9"):
Dalamud Information:
Do you have testing enabled?
No
Filter Issues
below is an example filter config for the craft list
Additional context
I am on the materia DC, in case this has an effect on the keys produced for houses.
Doing some digging through the ui text generation, I found the two keys that were produced by
InventoryTools.Lists.ListCategoryService.SourceHouseCategories
to be 160722211707421184 and 1021191215511896566. Neither of these keys begin with 9 and as such the check below fails for both.InventoryTools/InventoryTools/Logic/Filters/SourcesFilter.cs
Line 142 in b20ed3c
I also noticed there is no such check in
InventoryTools.Logic.Filters.DestinationsFilter
so assume that this solved a problem in the past that's no longer a problem.Removing this line produced the expected text.
The text was updated successfully, but these errors were encountered: