Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Login/Signup/Forgot-Password Pages "Sveltey" #6

Closed
scosman opened this issue Nov 17, 2023 · 2 comments
Closed

Make Login/Signup/Forgot-Password Pages "Sveltey" #6

scosman opened this issue Nov 17, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@scosman
Copy link
Contributor

scosman commented Nov 17, 2023

The login pages use @supabase/auth-ui-svelte but despite the name, these are wrappers of a general javascript framework, that doesn't produce Svelte. They can't be pre-rendered, are a bit slower to load, and show a visual stutter when applying style. I also don't love the error message handling (shown below, not inline), and the "in progress" indicator (too subtle, and can be below the viewport on mobile).

We can re-implement these in pure svelte for pre-render/consistency/speed, and fix the UX issues mentioned above.

P2: everything is functional and works fine as is.

Open for community input on this one.

@scosman scosman added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 17, 2023
@scosman scosman changed the title Make Login/Signup/Forgot-Password Pages "Svelty" Make Login/Signup/Forgot-Password Pages "Sveltey" Nov 17, 2023
@scosman scosman added the enhancement New feature or request label Jan 18, 2024
@scosman
Copy link
Contributor Author

scosman commented Jan 19, 2024

The supabase team is tracking the root issue here: supabase-community/auth-ui#230

I have a workaround, but will see if they fix it soon as it’s not critical.

Would still like svelte-rendering instead of that library so leaving open as P2.

@scosman
Copy link
Contributor Author

scosman commented Jan 23, 2024

In integrated my workaround in 9211be0 . Looks like no ETA on real fix, and easy enough to revert if they do.

Closing the issue. While I wouldn't mind moving away @supabase/auth-ui-svelte for performance, I realized it would be a ton of work. It's loading in all the oAuth options and icons. It would need to be kept up to date as Supabase adds/removes providers. Best to use the official solution for long term stability.

@scosman scosman closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant