Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task timer test on mac os variants sporadically failing #929

Open
gittiver opened this issue Oct 21, 2024 · 1 comment · Fixed by #949 · May be fixed by #976
Open

task timer test on mac os variants sporadically failing #929

gittiver opened this issue Oct 21, 2024 · 1 comment · Fixed by #949 · May be fixed by #976
Assignees
Labels
bug Something isn't working
Milestone

Comments

@gittiver
Copy link
Member

You can find the following:

/Users/runner/work/Crow/Crow/tests/unittest.cpp:3910
...............................................................................

/Users/runner/work/Crow/Crow/tests/unittest.cpp:3936: FAILED:
CHECK( a == false )
with expansion:
true == false

As the results a checked via sleep it may not work viable.
Error happens most of the time on macOS-latest or macOS-13

@gittiver gittiver added the bug Something isn't working label Oct 21, 2024
@gittiver gittiver added this to the v1.3 milestone Oct 23, 2024
@gittiver gittiver self-assigned this Oct 24, 2024
@gittiver gittiver linked a pull request Nov 25, 2024 that will close this issue
@gittiver gittiver reopened this Nov 29, 2024
@gittiver
Copy link
Member Author

The sleep works not reliable on macOs, so test will be changed to use asio timers for the checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant