New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make importable as GovUKFrontendJinja.init_app #22

Open

benvand opened this issue Sep 9, 2019 · 1 comment

Labels

discussion enhancement

Contributor

benvand commented Sep 9, 2019 •

edited by lfdebrux

Loading

https://github.com/alphagov/govuk-frontend-jinja/blob/master/govuk_frontend_jinja/flask_ext.py#L10

GovUKFrontendJinja.init_app ?

It doesn't seem to matter but does follow convention?

benvand added discussion enhancement labels

Contributor

lfdebrux commented Sep 26, 2019

The documentation for Flask seems to suggest that either form is good http://flask.palletsprojects.com/en/1.1.x/extensiondev/#initializing-extensions, I went for the function because I couldn't see a need for a class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment