Skip to content
This repository has been archived by the owner on Jan 31, 2025. It is now read-only.

Make importable as GovUKFrontendJinja.init_app #22

Open
benvand opened this issue Sep 9, 2019 · 1 comment
Open

Make importable as GovUKFrontendJinja.init_app #22

benvand opened this issue Sep 9, 2019 · 1 comment
Labels
discussion Something to talk about enhancement New feature or request

Comments

@benvand
Copy link
Contributor

benvand commented Sep 9, 2019

https://github.com/alphagov/govuk-frontend-jinja/blob/master/govuk_frontend_jinja/flask_ext.py#L10

GovUKFrontendJinja.init_app ?

It doesn't seem to matter but does follow convention?

@benvand benvand added discussion Something to talk about enhancement New feature or request labels Sep 9, 2019
@lfdebrux
Copy link
Contributor

The documentation for Flask seems to suggest that either form is good http://flask.palletsprojects.com/en/1.1.x/extensiondev/#initializing-extensions, I went for the function because I couldn't see a need for a class.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion Something to talk about enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants