From 028ffc66143e9ffcd55d566526a7135443ba28e8 Mon Sep 17 00:00:00 2001 From: Caleb Cox Date: Fri, 8 Nov 2024 11:56:29 -0600 Subject: [PATCH 1/3] Use setup-node@v4 Fixes error "Unable to find Node version 'nodejs 18.20.4 yarn 1.22.17'" --- .github/workflows/ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 67bf1bb9d..86619a679 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: name: tests steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v4 with: node-version-file: .tool-versions - name: ๐Ÿ“ฆ Install Dependencies @@ -34,7 +34,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v4 with: node-version-file: .tool-versions - name: ๐Ÿ“ฆ Install Dependencies @@ -45,7 +45,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v4 with: node-version-file: .tool-versions - name: ๐Ÿ“ฆ Install Dependencies @@ -56,7 +56,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v4 with: node-version-file: .tool-versions - name: ๐Ÿ“ฆ Install Dependencies @@ -67,7 +67,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v4 with: node-version-file: .tool-versions - name: ๐Ÿ“ฆ Install Dependencies @@ -80,7 +80,7 @@ jobs: if: github.event_name == 'push' steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v4 with: node-version-file: .tool-versions - name: ๐Ÿ“ฆ Install Dependencies From ab12f3788045a4dacdb6406b3c8a28e757afdc9c Mon Sep 17 00:00:00 2001 From: Caleb Cox Date: Fri, 8 Nov 2024 14:15:46 -0600 Subject: [PATCH 2/3] fixup! Remove webpack-inline-manifest-plugin --- webpack.config.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/webpack.config.js b/webpack.config.js index 4c26ea188..e59983b77 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -96,14 +96,12 @@ module.exports = (env = {}) => { filename: 'browserUnsupported.html', excludeAssets: /.*\.js/, // Only import CSS minify: htmlMinDefaults, - chunks: ['manifest'], }), new HtmlWebpackPlugin({ template: 'app/maintenanceMode.ejs', filename: 'maintenanceMode.html', excludeAssets: /.*\.js/, // Only import CSS minify: htmlMinDefaults, - chunks: ['manifest'], }), new HtmlWebpackSkipAssetsPlugin(), new FaviconsWebpackPlugin('./app/img/favicon.png'), From 90bbae1fb526cef84267cc04580a1cb846847019 Mon Sep 17 00:00:00 2001 From: Caleb Cox Date: Fri, 8 Nov 2024 14:34:52 -0600 Subject: [PATCH 3/3] Put the node version in .node-version Netlify cannot read .tool-versions when it builds the site. --- .github/workflows/ci.yml | 12 ++++++------ .node-version | 1 + .tool-versions | 1 - 3 files changed, 7 insertions(+), 7 deletions(-) create mode 100644 .node-version diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 86619a679..96155a61e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v4 with: - node-version-file: .tool-versions + node-version-file: .node-version - name: ๐Ÿ“ฆ Install Dependencies run: yarn install --immutable --immutable-cache - name: ๐Ÿงช Run Tests @@ -36,7 +36,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v4 with: - node-version-file: .tool-versions + node-version-file: .node-version - name: ๐Ÿ“ฆ Install Dependencies run: yarn install --immutable --immutable-cache - name: ๐Ÿ’จ ESLint @@ -47,7 +47,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v4 with: - node-version-file: .tool-versions + node-version-file: .node-version - name: ๐Ÿ“ฆ Install Dependencies run: yarn install --immutable --immutable-cache - name: โœ… TypeScript lint @@ -58,7 +58,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v4 with: - node-version-file: .tool-versions + node-version-file: .node-version - name: ๐Ÿ“ฆ Install Dependencies run: yarn install --immutable --immutable-cache - name: ๐Ÿ’… Prettier Check @@ -69,7 +69,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v4 with: - node-version-file: .tool-versions + node-version-file: .node-version - name: ๐Ÿ“ฆ Install Dependencies run: yarn install --immutable --immutable-cache --check-cache deploy: @@ -82,7 +82,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v4 with: - node-version-file: .tool-versions + node-version-file: .node-version - name: ๐Ÿ“ฆ Install Dependencies run: yarn install --immutable --immutable-cache - name: ๐Ÿ”จ Build diff --git a/.node-version b/.node-version new file mode 100644 index 000000000..17719ce25 --- /dev/null +++ b/.node-version @@ -0,0 +1 @@ +18.20.4 diff --git a/.tool-versions b/.tool-versions index c261b0d35..ba2b59c16 100644 --- a/.tool-versions +++ b/.tool-versions @@ -1,2 +1 @@ -nodejs 18.20.4 yarn 1.22.17