diff --git a/src/components/Contacts/ContactDetails/ContactDetailsHeader/ContactDetailsHeader.tsx b/src/components/Contacts/ContactDetails/ContactDetailsHeader/ContactDetailsHeader.tsx index cd068592e..fd3b66321 100644 --- a/src/components/Contacts/ContactDetails/ContactDetailsHeader/ContactDetailsHeader.tsx +++ b/src/components/Contacts/ContactDetails/ContactDetailsHeader/ContactDetailsHeader.tsx @@ -84,7 +84,7 @@ export const ContactDetailsHeader: React.FC = ({ }, [loading]); return ( - + @@ -109,7 +109,10 @@ export const ContactDetailsHeader: React.FC = ({ onClick={() => setEditPartnershipModalOpen(true)} aria-label={t('Edit Partnership Info')} > - + )} diff --git a/src/components/Contacts/ContactDetails/ContactDetailsTab/ContactDetailsTab.test.tsx b/src/components/Contacts/ContactDetails/ContactDetailsTab/ContactDetailsTab.test.tsx index 730e8c5d5..522d773b5 100644 --- a/src/components/Contacts/ContactDetails/ContactDetailsTab/ContactDetailsTab.test.tsx +++ b/src/components/Contacts/ContactDetails/ContactDetailsTab/ContactDetailsTab.test.tsx @@ -307,14 +307,16 @@ describe('ContactDetailTab', () => { await waitFor(() => expect(queryByText('Loading')).not.toBeInTheDocument()); }); - it('should open edit contact other details modal', async () => { - const { queryByText } = render(); + it('should open and close Edit Contact Other Details modal', async () => { + const { queryByText, getByTestId, getByText, getByLabelText } = render( + , + ); await waitFor(() => expect(queryByText('Loading')).not.toBeInTheDocument()); - }); + userEvent.click(getByTestId('Edit Other')); + expect(getByText('Edit Contact Other Details')).toBeInTheDocument(); + + userEvent.click(getByLabelText('Close')); - it('should close edit contact other details modal', async () => { - const { queryByText } = render(); - await waitFor(() => expect(queryByText('Loading')).not.toBeInTheDocument()); await waitFor(() => expect(queryByText('Edit Contact Other Details')).not.toBeInTheDocument(), ); diff --git a/src/components/Contacts/ContactDetails/ContactDetailsTab/ContactDetailsTab.tsx b/src/components/Contacts/ContactDetails/ContactDetailsTab/ContactDetailsTab.tsx index 21573f70e..81b502122 100644 --- a/src/components/Contacts/ContactDetails/ContactDetailsTab/ContactDetailsTab.tsx +++ b/src/components/Contacts/ContactDetails/ContactDetailsTab/ContactDetailsTab.tsx @@ -131,7 +131,7 @@ export const ContactDetailsTab: React.FC = ({ aria-label={t('Edit')} style={{ marginLeft: 5 }} > - + diff --git a/src/components/Contacts/ContactDetails/ContactDetailsTab/Other/EditContactOtherModal/EditContactOtherModal.tsx b/src/components/Contacts/ContactDetails/ContactDetailsTab/Other/EditContactOtherModal/EditContactOtherModal.tsx index 4bd3ea278..ed210be29 100644 --- a/src/components/Contacts/ContactDetails/ContactDetailsTab/Other/EditContactOtherModal/EditContactOtherModal.tsx +++ b/src/components/Contacts/ContactDetails/ContactDetailsTab/Other/EditContactOtherModal/EditContactOtherModal.tsx @@ -433,11 +433,9 @@ export const EditContactOtherModal: React.FC = ({ > {languages.map( (value) => - value?.value && ( - + value.id && + value.value && ( + {t(value.value)} ), diff --git a/src/components/Contacts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonName/PersonName.tsx b/src/components/Contacts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonName/PersonName.tsx index 52f94e953..09aa9dfe5 100644 --- a/src/components/Contacts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonName/PersonName.tsx +++ b/src/components/Contacts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/PersonName/PersonName.tsx @@ -1,13 +1,6 @@ import React, { useRef } from 'react'; import UploadIcon from '@mui/icons-material/Upload'; -import { - Avatar, - Box, - Grid, - IconButton, - TextField, - Typography, -} from '@mui/material'; +import { Avatar, Grid, IconButton, TextField, Typography } from '@mui/material'; import { styled } from '@mui/material/styles'; import { FormikProps } from 'formik'; import { useTranslation } from 'react-i18next'; @@ -82,7 +75,7 @@ export const PersonName: React.FC = ({ return ( <> - {person ? ( + {person && ( @@ -102,13 +95,11 @@ export const PersonName: React.FC = ({ ref={fileRef} onChange={handleFileChange} /> - - {`${ - person.firstName || '' - } ${person.lastName || ''}`} + + {`${person.firstName || ''} ${person.lastName || ''}`} - ) : null} + )} diff --git a/src/components/Contacts/ContactDetails/ContactDonationsTab/PartnershipInfo/EditPartnershipInfoModal/EditPartnershipInfoModal.tsx b/src/components/Contacts/ContactDetails/ContactDonationsTab/PartnershipInfo/EditPartnershipInfoModal/EditPartnershipInfoModal.tsx index 880a375d1..6aff9ea04 100644 --- a/src/components/Contacts/ContactDetails/ContactDonationsTab/PartnershipInfo/EditPartnershipInfoModal/EditPartnershipInfoModal.tsx +++ b/src/components/Contacts/ContactDetails/ContactDonationsTab/PartnershipInfo/EditPartnershipInfoModal/EditPartnershipInfoModal.tsx @@ -233,7 +233,7 @@ export const EditPartnershipInfoModal: React.FC< = ({ }) } style={{ - height: `Max(calc(100vh - ${infiniteListRectTop}px), 500px)`, + height: `max(100vh - ${infiniteListRectTop}px, 500px)`, }} data-testid="virtuoso-item-list" /> diff --git a/src/components/Contacts/ContactFlow/ContactFlowRow/ContactFlowRow.test.tsx b/src/components/Contacts/ContactFlow/ContactFlowRow/ContactFlowRow.test.tsx index 31b633ab5..b3d75af76 100644 --- a/src/components/Contacts/ContactFlow/ContactFlowRow/ContactFlowRow.test.tsx +++ b/src/components/Contacts/ContactFlow/ContactFlowRow/ContactFlowRow.test.tsx @@ -45,7 +45,7 @@ describe('ContactFlowRow', () => { , ); expect(getByText('Test Name')).toBeInTheDocument(); - expect(getByTitle('Star')).toBeInTheDocument(); + expect(getByTitle('Unstar')).toBeInTheDocument(); }); it('should call contact selected function', () => { diff --git a/src/components/Tool/Appeal/Flow/ContactFlowRow/ContactFlowRow.test.tsx b/src/components/Tool/Appeal/Flow/ContactFlowRow/ContactFlowRow.test.tsx index 1f9c41ccf..aa3b1ebfd 100644 --- a/src/components/Tool/Appeal/Flow/ContactFlowRow/ContactFlowRow.test.tsx +++ b/src/components/Tool/Appeal/Flow/ContactFlowRow/ContactFlowRow.test.tsx @@ -83,7 +83,7 @@ describe('ContactFlowRow', () => { />, ); expect(getByText(defaultContact.name)).toBeInTheDocument(); - expect(getByTitle('Star')).toBeInTheDocument(); + expect(getByTitle('Unstar')).toBeInTheDocument(); }); it('should call contact selected function', () => { diff --git a/src/components/common/StarredItemIcon/StarredItemIcon.tsx b/src/components/common/StarredItemIcon/StarredItemIcon.tsx index 4d11b14b4..f07464908 100644 --- a/src/components/common/StarredItemIcon/StarredItemIcon.tsx +++ b/src/components/common/StarredItemIcon/StarredItemIcon.tsx @@ -21,7 +21,7 @@ const StarOutline = styled(StarBorderOutlined)(({ theme }) => ({ export const StarredItemIcon: React.FC = ({ isStarred }) => { return isStarred ? ( - + ) : ( ); diff --git a/src/lib/data/languages.ts b/src/lib/data/languages.ts index 2ff9b9413..d28a79c2d 100644 --- a/src/lib/data/languages.ts +++ b/src/lib/data/languages.ts @@ -43,12 +43,9 @@ export const languages: IdValue[] = [ }, ]; -// type FormatLanguageProps = { id: string; value: string }[] | undefined; -type FormatLanguageProps = IdValue[] | undefined; - export const formatLanguage = ( language: string | undefined | null, - languagesList: FormatLanguageProps = languages, + languagesList: IdValue[] = languages, ): string => { const name = languagesList.find(({ id }) => id === language)?.value; return name ?? '';