MPDX-8116 - Fix Commitment Info - Infinity Scroll #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjames111
added
On Staging
|
Preview branch generated at https://MPDX-8116-fix-commitment-info-infinity-scroll.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 40524d1 No significant changes found |
canac
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Thanks for adding infinite scroll! I have 98 items and when I scroll fast, the screen goes blank because rendering is taking 0.3s on same frames. I'm not sure why the rendered components are so costly to render. But that was a problem before this PR, so I'm approving.
| @@ -107,6 +113,10 @@ export enum UpdateTypeEnum { | |||
| Hide = 'HIDE', | |||
| } | |||
|
|
|||
| const ItemOverride: React.ComponentType<ItemProps> = (props) => ( | |||
| <ItemWithBorders disableGutters disableHover={true} {...props} /> | |||
There was a problem hiding this comment.
Suggested change
| <ItemWithBorders disableGutters disableHover={true} {...props} /> | |
| <ItemWithBorders disableGutters disableHover {...props} /> |
|
Yeah it's not great, I tried playing around with it but couldn't get any better results. |
wjames111
force-pushed
the
MPDX-8116-fix-commitment-info-infinity-scroll
branch
from
5a8f16e to
058c433
Compare
wjames111
force-pushed
the
MPDX-8116-fix-commitment-info-infinity-scroll
branch
from
cbd0b1d to
4e78626
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist: