MPDX-8304 Next Action autoselected

[caleballdrin]

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=3&view=detail&selectedIssue=MPDX-8304&sprint=1282#

• When the result of a task is changed, set the next action to the same action of the task that was completed (if it is an option)
• Set result and nextAction default values to null to avoid a controlled/uncontrolled state error

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
• I have requested a review from another person on the project

[github-actions]

Preview branch generated at https://MPDX-8304-next-action.d3dytjb8adxkk5.amplifyapp.com

[github-actions]

Bundle sizes [mpdx-react]

Compared against 4f9c22b

No significant changes found

[canac]

Great catch with the uncontrolled inputs! Here's another one that should probably change in TaskModalCompleteForm.tsx. Sorry I can't comment on the line because it wasn't changed.

<ActivityTypeAutocomplete
  options={nextActions}
  value={nextAction || undefined} // <------
  label={t('Next Action')}
  onChange={(nextAction) =>
    setFieldValue('nextAction', nextAction)
  }
  activityTypes={activityTypes}
/>

[canac]

Looks great! I'm excited to have this feature back!

[canac]

@caleballdrin Besides my suggestions for fixing the lint error, this looks good! I wasn't even seeing the uncontrolled input warning either (unless I was doing something wrong). EDIT: I do see it now when logging a task.