Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8129 - Upgrade @react-google-maps/api to 2.20.3 #1158

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

wjames111
Copy link
Contributor

@wjames111 wjames111 commented Oct 25, 2024

Description

  • Jira ticket 8129
  • Upgrade @react-google-maps/api to 2.20.3

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@wjames111 wjames111 added On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview labels Oct 25, 2024
@wjames111 wjames111 self-assigned this Oct 25, 2024
Copy link
Contributor

Preview branch generated at https://MPDX-8129-google-map-update.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against ada0000

Dynamic import Size (gzipped) Diff
../src/components/Contacts/ContactDetails/ContactDetailsTab/DynamicContactDetailsTab.tsx -> ./ContactDetailsTab 78.41 KB +3.45 KB
../src/components/Contacts/ContactDetails/ContactDetailsTab/Mailing/AddAddressModal/DynamicAddAddressModal.tsx -> ./AddAddressModal 75.78 KB +3.45 KB
../src/components/Contacts/ContactDetails/ContactDetailsTab/Mailing/EditContactAddressModal/DynamicEditContactAddressModal.tsx -> ./EditContactAddressModal 75.88 KB +3.45 KB
../src/components/Contacts/ContactsMap/DynamicContactsMap.tsx -> ./ContactsMap 36.22 KB +3.45 KB
../src/components/Layouts/Primary/TopBar/Items/AddMenu/Items/CreateMultipleContacts/DynamicCreateMultipleContacts.tsx -> ./CreateMultipleContacts 80.01 KB +3.45 KB

@dr-bizz
Copy link
Contributor

dr-bizz commented Oct 29, 2024

@wjames111 Did you mean to request a review for one of us devs?

@wjames111
Copy link
Contributor Author

@dr-bizz I wasn't really sure about this one yet. I don't think upgrading the package will affect the api upgrade. I'd assume whoever manages the api would need to opt into the 3.6 version for us to test, but not entirely sure.

@dr-bizz
Copy link
Contributor

dr-bizz commented Oct 30, 2024

@wjames111 From reading through the most up-to-date code on the package @react-google-maps/api, it looks like we could pass in a version: https://www.npmjs.com/package/@react-google-maps/api?activeTab=code, but they are using weekly as default, which is good.

On the MPDX maps page, I opened the console and typed google.maps.version to return the version of google API we are using, it returned: 3.58.10.

We need to be on the latest version or at least 3.60.0, so lets upgrade @react-google-maps/api to see if that helps.

@wjames111
Copy link
Contributor Author

@dr-bizz thanks for digging this info up. We could pass in the specific version for testing but it looks like 3.60 isn't available yet, even 3.59 isn't available until November. I'll move forward with this PR so we have the most up to date package, let me know if we should try anything else.

@wjames111 wjames111 requested a review from dr-bizz October 30, 2024 14:58
@wjames111
Copy link
Contributor Author

@dr-bizz I may have spoken to soon. If I pass in Alpha I get the new map controls.
Screenshot 2024-10-30 at 11 03 53 AM

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you have created a new PR to test the new controls. For this PR, updating the NPM package; it looks great. Good work.

@dr-bizz
Copy link
Contributor

dr-bizz commented Oct 31, 2024

The workflow looks great too!

@wjames111 wjames111 merged commit 121cd06 into main Oct 31, 2024
21 checks passed
@wjames111 wjames111 deleted the MPDX-8129-google-map-update branch October 31, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants