-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX-8129 - Upgrade @react-google-maps/api to 2.20.3 #1158
Conversation
Preview branch generated at https://MPDX-8129-google-map-update.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against ada0000
|
@wjames111 Did you mean to request a review for one of us devs? |
@dr-bizz I wasn't really sure about this one yet. I don't think upgrading the package will affect the api upgrade. I'd assume whoever manages the api would need to opt into the 3.6 version for us to test, but not entirely sure. |
@wjames111 From reading through the most up-to-date code on the package On the MPDX maps page, I opened the console and typed We need to be on the latest version or at least |
@dr-bizz I may have spoken to soon. If I pass in Alpha I get the new map controls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you have created a new PR to test the new controls. For this PR, updating the NPM package; it looks great. Good work.
The workflow looks great too! |
Description
Checklist: