-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX-8429 Fix 502 error on 14-month report #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when the query takes to long.
Preview branch generated at https://MPDX-8429.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 8031fd4
|
3 tasks
canac
reviewed
Nov 5, 2024
src/components/Reports/FourteenMonthReports/handleFourteenMonthReportData.ts
Outdated
Show resolved
Hide resolved
src/components/Reports/FourteenMonthReports/FourteenMonthReport.tsx
Outdated
Show resolved
Hide resolved
I tested that the request is working now when using a direct REST API call ✅ |
… server when the query takes to long.
canac
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested again, and it still works. Thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 14-month Proxy GraphQL query always failed on
[email protected]
's account. This is due to the amount of data being returned, and the server couldn't cope.For a very quick fix, I have called the API directly from the frontend, instead of using Next.js backend. I believe this will fix the issue for now, but the main issue is that we need to make this query into a proper GraphQL query.
I hope this doesn't cause the query to be slow for others. - In my testing, it has somewhat sped it up.
To Test:
[email protected]
and see if the page returns a 502.Slack Message: https://cru-main.slack.com/archives/GG47BDJDU/p1730814260125489
Jira Ticket: https://jira.cru.org/browse/MPDX-8429
Checklist: