-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no-Jira] Deduplicate frontend yarn packages #1197
Conversation
Preview branch generated at https://yarn-dedupe.d3dytjb8adxkk5.amplifyapp.com |
Bundle sizes [mpdx-react]Compared against 5f6646c No significant changes found |
@dr-bizz I guess this doesn't actually change the bundle sizes. I can close this if you think it's not worth doing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you know it was duplicated, and then how did you remove it. Is there a yarn command?
@dr-bizz |
@dr-bizz Did you have any more thoughts on this? The change in bundle size isn't enough to trigger the bundle analyzer comment, but it goes down by 235 bytes for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are fine to merge this, even if it doesn't change that much
Description
I hope this will decrease bundle sizes because emotion packages won't be included in the bundle multiple times anymore.
Checklist: