Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPDX-8472] Generate URLs with current accountListId #1208

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Nov 21, 2024

Description

Due to insufficient dependencies, getContactHrefObject was generating URLs with an old accountListId.

Reproduction

Testing

  • Follow the same steps above in the preview environment
  • Verify that the account list id does not change in the URL and that there is no GraphQL warning

MPDX-8472

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Nov 21, 2024
@canac canac requested a review from dr-bizz November 21, 2024 14:07
@canac canac self-assigned this Nov 21, 2024
Copy link
Contributor

Preview branch generated at https://8472-wrong-account-list.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Bundle sizes [mpdx-react]

Compared against 45df179

No significant changes found

@canac
Copy link
Contributor Author

canac commented Nov 21, 2024

@dr-bizz You can hold off on reviewing this. In preview it seems to be reverting back to showing no contact when you click on a contact.

@canac
Copy link
Contributor Author

canac commented Nov 21, 2024

@dr-bizz OK, I believe I fixed the bug, so feel free to review whenever you're ready.

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@canac canac force-pushed the 8472-wrong-account-list branch from b7264d1 to 8c2c7bf Compare November 22, 2024 15:30
@canac canac enabled auto-merge November 22, 2024 15:30
@canac canac merged commit d3c5364 into main Nov 22, 2024
17 checks passed
@canac canac deleted the 8472-wrong-account-list branch November 22, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants